Updating Data in access database

Question

0.00/5 (No votes)

See more:

On trying to update the data in access database..no error is displayed yet the data does not get updated...what could be wrong? here is some of the code under the update button.

VB

connect()

'checking wherether centre number exists in database
Try
    If Not cnn.State = ConnectionState.Open Then
        'open connection if it is not yet open
        cnn.Open()
    End If

    cmd.Connection = cnn

    cmd.CommandText = "SELECT count(motonum) from moto where motonum = '" & TextBox1.Text & "'"

    myData = cmd.ExecuteReader

    While myData.Read()
        dcount = myData(0)
    End While
    myData.Close()
    'if number exists.......
    MessageBox.Show(dcount)
    If dcount <> 0 And Me.TextBox1.Text <> Me.TextBox1.Tag Then
        MsgBox("Centre number " & TextBox1.Text + " is Already Registered. Please Try another Number!", MsgBoxStyle.Critical)
        'if number doesnt exist......update
    Else

        cmd.CommandText = "UPDATE moto " & _
                        " SET motonum='" & Me.TextBox1.Text & _
                        "', motocat='" & Me.TextBox1.Text.Trim & "'" & _
                        "where motonum='" & Me.TextBox1.Tag & "'"
        cmd.ExecuteNonQuery()
        MessageBox.Show("updated")

    End If

Catch ex As Exception
    MessageBox.Show(ex.ToString)
End Try

Posted 18-Jan-13 23:41pm

braop

Updated 19-Jan-13 0:04am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2013-01-18T23:50:00

Solution 1

Who knows? You don't - and we don't - and none of us can find out, because you are throwing away any and all information on the cause of the error.

When you use an empty Catch block, you are saying "I don't care what the error is, let's ignore it and continue".

Add some code - at a bare minimum:

VB

Catch ex As Exception
    MessageBox.Show(ex.Message)
End Try

Which will give you a start of finding what the problem is caused by!

Posted 18-Jan-13 23:50pm

OriginalGriff

Comments

braop 19-Jan-13 6:07am

Thankx. With that included no single error is displayed ...MessageBox.show("updated") is displayed but value isn't updated

OriginalGriff 19-Jan-13 6:18am

Are you sure?
Check your connection string, and look at that exact database - make certain that it is exactly the database file you think it is.
If you have added the DB as a project file, then it is possible that the DB is copied to your debug directory every time the project is run, or that there is a copy of the DB that you are updating, and you are checking via the original version.

BTW: Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.