I need to loop in buttons

Question

1.00/5 (1 vote)

See more:

I need to loop in buttons to save time and apply the function ElipsControl() to all buttons. Repetitive code

ex : ...
            ElipseControl nn = new ElipsControl(); 
            nn.CornerRadius = 20;
            nn.TargetControl = button3;
            nn.CornerRadius = 20;
            nn.TargetControl = button4;
            nn.CornerRadius = 20;
            nn.TargetControl = button5;
            nn.CornerRadius = 20;
            ...

What I have tried:

ElipseControl el = new ElipseControl();
            foreach (var btn in this.Controls)
            {
                if (btn.GetType() == typeof(Button))
                {
                    //((Button) btn).Controls;
                    el.TargetControl = (Button)btn;
                    el.CornerRadius = 20;
                }
            }

it don't work ?

Posted 8-Jun-21 20:52pm

GSylvain55

Updated 10-Jun-21 19:35pm

v2

Add a Solution

Comments

Maciej Los 9-Jun-21 3:23am

We know what you want, but! we don't know what kind of issue do you have...
Can you be more specific and provide more details?

GSylvain55 9-Jun-21 10:13am

I understand, but I try it and not working.
My buttons are in 3 panels.
Does that change anything ?
I change the modifier to public for panels.

C#Copy Code

foreach (var c in Controls)    {    //if (btn.GetType() == typeof(Button btn))      if (c is Button btn)         {           ElipseControl el = new ElipseControl();           el.TargetControl = (Control) btn;           el.CornerRadius = 20;         }

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2021-06-08T21:42:00

You definitely can't do it like that: you are creating a single instance of an ElipseControl and re-using it inside the loop. That means that each time round, you overwrite the settings you applied the previous time - and that means that the result will only be set for the last Button in your collection.
If you want to apply this to all buttons, you probably need to create a new instance of ElipseControl for each Button - and that means moving the code inside the loop. I'd also use more modern code for the loop body:

C#

foreach (Control c in Controls)
   {
   if (c is Button btn)
      {
      ElipseControl el = new ElipseControl();
      el.TargetControl = btn;
      el.CornerRadius = 20;
      }
   }

GSylvain55 · Accepted Answer · 2021-06-10T19:35:00

I find it, Yes !
It's work. I need just give de name of panels before.

C#

foreach (Control c in PanCla.Controls)
            {
                if (c is Button)
                {
                    
                    ElipseControl el = new ElipseControl();
                    el.TargetControl = c ;
                    el.CornerRadius = 20;
                }
            }

Thank You.

I need to loop in buttons

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0