Shell script program to add numbers from command line which are greater than 10

Question

0.00/5 (No votes)

See more:

I have written a shell script that takes arguments from the command line and adds them only if they are greater than 10 I have coded it well but not able to understand why is showing the command not found error

What I have tried:

#!/bin/sh
sum=0
for i in $@
do
if [$@ -gt 10]
then
sum=$((sum+i))
else
continue
fi
done
echo $sum

Posted 10-Feb-21 1:27am

Ziad Ahmed Khan

Updated 10-Feb-21 2:06am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Accepted Answer · 2021-02-10T02:06:00

Solution 1

Your if statement does not refer to the individual value, it should be $i not $@. Also the square brackets require spaces to separate them from the parameters. Try this:

Bash

#!/bin/sh
sum=0
for i in $@
do
    if [ $i -gt 10 ]
    then
        sum=$((sum+i))
    else
            continue
    fi
done
echo $sum

Posted 10-Feb-21 2:06am

Richard MacCutchan

Comments

CPallini 10-Feb-21 8:09am

5.

Richard MacCutchan 10-Feb-21 8:47am

Thanks. I won't tell you how long it took me.