How to get a string into a char variable correctly?

Question

0.00/5 (No votes)

See more:

Hi, How do I get a string into a char variable correctly?
I have this code in C programming language but it doesn't work.

C

#include <stdio.h>
#include <stdlib.h>

int main(){

    char yesman;

    printf("Are you a yes man? ");
    scanf("%c", &yesman);

    /* getchar(); */

    if(yesman == 'yes'){
        printf("It is bad to be a yes man.");
    } else if(yesman == 'no'){
     printf("Good.");
    } else if(yesman == 'No.'){
     printf("Good, and you can spell at that.");
    } else {
     printf("Invalid Operator");
    }

    return 0;
}

What I have tried:

I have tried with

char yesman[4];

to try to allocate room for the characters in the string but it did not help.

Posted 22-Dec-20 16:31pm

Mieczyslaw1683

Updated 22-Dec-20 20:08pm

CPallini

v2

Add a Solution

2 solutions

Solution 1

This should work :

C++

char yesman[64];
scanf( "%s", yesman );

I prefer to call gets or fgets - C++ Reference[^]. You can pass the stdin handle to it. Keep in mind that a newline character will be included with the string. It can be removed with this function :

C++

void RemoveNewLines( char * buffer )
{
    int length = (int) strlen( buffer );
    for( int n = length - 1; n >= 0; --n )
    {
       if( buffer[ length ] == '\r' )
           buffer[ length ] = 0;    // set to null
       else if( buffer[ length ] == '\n' )
           buffer[ length ] = 0;    // set to null
       else
           break;                   // not a newline so bail out
    }
}

Posted 22-Dec-20 17:47pm

Rick York

Comments

CPallini 23-Dec-20 1:56am

5.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2020-12-22T20:08:00

In addition to Rick remarks,

Quote:
if(yesman == 'yes'){

That's not the correct way to compare C strings (and 'yes' is not a valid string literal), you should use the strcmp (or strncmp) function[^].
Try

C

#include <stdio.h>
#include <string.h>
#include <stdlib.h>

int main()
{
  char yesman[256];

  printf("Are you a yes man? ");

  if ( scanf("%s", yesman) == 1)
  {
    if( strcmp( yesman, "yes") == 0)
    {
        printf("It is bad to be a yes-man.\n");
    }
    else if( strcmp(yesman, "no")==0 )
    {
     printf("Good.\n");
    }
    else if( strcmp(yesman, "No.")==0)
    {
      printf("Good, and you can spell at that.\n");
    }
    else
    {
     printf("Invalid Operator\n");
    }
  }
  return 0;
}