How do I save my data now in SQL server

Question

1.00/5 (1 vote)

See more:

I did 2 tables in database using one button. Now why my data is not saving in database ?

What I have tried:

C#

SqlDataAdapter da2 = new SqlDataAdapter("SELECT isnull(max(cast(ID as int)),0)+1 FROM LAB_SH_LINE", con);
                DataTable dt2 = new DataTable();
                da2.Fill(dt2);
                string sid2 = Prog + DateTime.Now.ToString("yyMMdd") + '-' + ((int)dt.Rows[0][0]).ToString("000");

                if (cmd.Connection.State == ConnectionState.Open)
                {
                    cmd.Connection.Close();
                }
                con.Open();
                SqlCommand cmd2 = new SqlCommand("Insert into LAB_SH_LINE values(@sid,@Value)", con);
                cmd2.Parameters.AddWithValue("sid", sid2);
                cmd2.Parameters.AddWithValue("Value", TextBox4.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox5.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox6.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox7.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox8.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox9.Text);
                cmd2.Parameters.AddWithValue("Value", TextBox10.Text);
                cmd.Parameters.AddWithValue("Water_Level", DropDownList5.SelectedValue);
                cmd.ExecuteNonQuery();

Posted 23-Sep-20 17:54pm

Ravindran12

Updated 23-Sep-20 20:13pm

Maciej Los

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-09-23T20:13:00

Do yourself a favour: go back to your previous question and read what I said there yesterday: How do I save these data in db[^]
With the exception of the "trailing comma" you have ignored all of it.

So a summary of the points you have already been given:
1) Never do "anonymous inserts"
2) You almost certainly shouldn't be inserting ID values
3) You need to specify a value for each of the parameters in your INSERT statement
4) The parameter names must match up in the AddWithValue call and the INSERT statement

You need to fix these things!

And now the continuation of "how not to do INSERT". :sigh:

What on earth do you expect SQL to do with "Water_Level" as a parameter? You don't even try to refer to it in the INSERT statement so it has no idea at all that it should even look for a parameter of that name.

Where are the textbox values supposed to go? You're giving them all the same "parameter name"!
If you want to add multiple textboxes to your row, you need to list them as different parameter names, and refer to them as such in your INSERT statement.

Stop guessing. Start thinking, and stop ignoring what we say in the hope that you know better so it it'll all work out in the end if you just guess some more! It won't...