Please me to solve this problem

Question

1.00/5 (1 vote)

See more:

Server Error in '/' Application.

An expression of non-boolean type specified in a context where a condition is expected, near 'Name'.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.Data.SqlClient.SqlException: An expression of non-boolean type specified in a context where a condition is expected, near 'Name'.

What I have tried:

Source Error:

Line 19: String checkuser = "select count(*) from UserData where User Name=' " + TextBoxUN.Text + "'";
Line 20: SqlCommand com = new SqlCommand(checkuser, conn);
Line 21: int temp = Convert.ToInt32(com.ExecuteScalar().ToString());
Line 22: if (temp == 1)
Line 23: {

Posted 7-Sep-20 23:51pm

Member 14910143

Updated 7-Sep-20 23:58pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2020-09-07T23:55:00

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Beyond that, you have a space in your column name. You need to properly quote the column name for the query to work.

C#

const string checkuser = "select count(*) from UserData where [User Name] = @UserName";
using (SqlConnection connection = new SqlConnection("..."))
using (SqlCommand command = new SqlCommand(checkuser, connection))
{
    command.Parameters.AddWithValue("@UserName", TextBoxUN.Text);
    
    connection.Open();
    object result = command.ExecuteScalar();
    
    int temp = (result == null || Convert.IsDBNull(result)) ? 0 : Convert.ToInt32(result);
    if (temp != 0)
    {
        ...
    }
}

Ideally you should update your database so that you don't use "special" characters or whitespace in any table or column names.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Sandeep Mewara · Answer 2 · 2020-09-07T23:58:00

2 things:
First off, bad way of getting data from database. Totally open for security threat via SQL Injection.
Read about protecting from SQL Injection here: SQL Injection Mitigation: Using Parameterized Queries[^]

Second,
believe 'User Name' s the coumn name with space in your database. If so, put that in square brackets:

C#

String checkuser = "select count(*) from UserData where [User Name]=' " + TextBoxUN.Text + "'";

Currently, User name is not considered one word by SQL and throws back an error.

Please me to solve this problem

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0