How to save data in database C# winform

Question

1.00/5 (1 vote)

See more:

I use this Code for save TextBox Data into DataBase, but I have a Problem when I click save Button code run without any error and MessageBox Show "Recourd is saved",

but Data Not save in my DataBase,
I think Problem Not in My DataBase Connection Because My AutoNumber Code Work Fine

this is my Code

XML

<configuration>
    <configsections>
        <sectiongroup name="userSettings" type="System.Configuration.UserSettingsGroup, System, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089">
            <section name="Project1.Properties.Settings">
        
    
    <connectionstrings>
        <add name="Project1.Properties.Settings.DataFileConnectionString" 
  connectionstring="Data Source=(LocalDB)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Data\DataFile.mdf;Integrated Security=True" providername="System.Data.SqlClient"/>
    
    <startup> 
        <supportedruntime version="v4.0" sku=".NETFramework,Version=v4.5">

What I have tried:

C#

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;
using System.Configuration;
using System.Data.SqlClient;

namespace Project1
{
    public partial class NewStudantEntry : Form
    {
        public NewStudantEntry()
        {
            InitializeComponent();
        }

        SqlConnection con = new SqlConnection(ConfigurationManager.ConnectionStrings["Project1.Properties.Settings.DataFileConnectionString"].ConnectionString);

        private void NewStudantEntry_Load(object sender, EventArgs e)
        {
            Autonumber();
        }

        // Auto Number in TextBox
        private void Autonumber()
        {
            string Query = "select MAX(StudantNumber) from StudantData";
            SqlCommand cd = new SqlCommand(Query, con);
            try
            {
                con.Open();
                var cont = cd.ExecuteScalar();
                var count = (cont == DBNull.Value ? 1 : Convert.ToInt32(cont) + 1);
                txtStudantNumber.Text = count.ToString("000");
                txtStudantNumber.Enabled = false;

            }

            finally
            {
                con.Close();
            }
        }

        private void SaveRecord()
        {
            string cmdstring = "Insert into StudantData (StudantNumber, ApplicationDate, StudantName, FatherName, Address, Address1, MobileNo, SecMobileNo, City, District, State, PinCode, Remark, UserID) VALUES (@StudantNumber, @ApplicationDate, @StudantName, @FatherName, @Address, @Address1, @MobileNo, @SecMobileNo, @City, @District, @State, @PinCode, @Remark, @UserID)";
            {
                using (SqlCommand cmd = new SqlCommand(cmdstring, con))
                {
                    con.Open();

                    cmd.Parameters.AddWithValue("@StudantNumber", txtStudantNumber.Text);
                    cmd.Parameters.AddWithValue("@ApplicationDate", dtpApplicationDate.Value.Date);
                    cmd.Parameters.AddWithValue("@StudantName", txtStudantName.Text);
                    cmd.Parameters.AddWithValue("@FatherName", txtFatherName.Text);
                    cmd.Parameters.AddWithValue("@Address", txtAddress.Text);
                    cmd.Parameters.AddWithValue("@Address1", txtAddress1.Text);
                    cmd.Parameters.AddWithValue("@MobileNo", txtMobileNo.Text);
                    cmd.Parameters.AddWithValue("@SecMobileNo", txtSecMobileNo.Text);
                    cmd.Parameters.AddWithValue("@City", txtCity.Text);
                    cmd.Parameters.AddWithValue("@District", txtDist.Text);
                    cmd.Parameters.AddWithValue("@State", txtState.Text);
                    cmd.Parameters.AddWithValue("@PinCode", txtPinCode.Text);
                    cmd.Parameters.AddWithValue("@Remark", txtRemark.Text);
                    cmd.Parameters.AddWithValue("@UserID", "Admin");

                    cmd.ExecuteNonQuery();
                    MessageBox.Show("Recourd is saved", "Success", MessageBoxButtons.OK, MessageBoxIcon.Information);
                    con.Close();
                }
            }
        }

        private void btnSave_Click(object sender, EventArgs e)
        {
            SaveRecord();
        }
    }
}

Posted 6-Aug-20 3:34am

Amar chand123

Updated 7-Aug-20 22:56pm

v5

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-08-06T04:10:00

Do not do "autonumbering" like that: it's a recipe for some really nasty bugs. SQL Server is a multi-user database, so it's really quite possible that between you asking for the highest number and writing your data that any number of other user can have done the same. All it takes is one pair of users to end up with the same number, and the data in your DB can start to get seriously compromised.

Instead, use an IDENTITY field in SQL Server (or a UNIQUEIDENTIFIER) and let SQL Server sort out the uniqueness - it will get it right! It's also a lot more efficient than two round trips to SQL ...

As far as the problem you have noticed, as Garth says the debugger is the place to start. But assuming you do get a "Recourd is saved" (sic) message box, then you need to look at how you are determining that the row is not being stored: what makes you so sure it isn't? Since you get the MessageBox, you aren't getting an exception in that code - which implies that you aren't looking at the right place when you check!

Richard MacCutchan · Answer 2 · 2020-08-06T05:42:00

Solution 4

You make the classic mistake of not using the code correctly. As you can see from SqlCommand.ExecuteNonQuery Method (System.Data.SqlClient) | Microsoft Docs[^], there is a return value to tell you whether it worked or not. But you have ignored that and just assumed that it worked. Never post "success" messages unless you first check the result of the method call.

Posted 6-Aug-20 5:42am

Richard MacCutchan

Comments

Amar chand123 8-Aug-20 7:07am

When i change "Data Source=(LocalDB)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Data\DataFile.mdf;Integrated Security=True"
to
"Data Source=(LocalDB)\MSSQLLocalDB;AttachDbFilename=C:\Users\HP\source\repos\Project1\Project1\Data\DataFile.mdf;Integrated Security=True"

my Code Woke Fine and Data Save and show in my DataBase Correctly
but I Don't Know, Why?

Richard MacCutchan 8-Aug-20 8:17am

There is no way that we can find out. You need to use the debugger to step through the code and find out what is happening.

Garth J Lancaster · Answer 3 · 2020-08-06T03:55:00

I think you should use your debugger and make absolutely sure your code in SaveRecord() is being run.

Set a breakpoint on this line

string cmdstring = "Insert into StudantData (StudantNumber, ApplicationDate, StudantName, FatherName, Address, Address1, MobileNo, SecMobileNo, City, District, State, PinCode, Remark, UserID) VALUES (@StudantNumber, @ApplicationDate, @StudantName, @FatherName, @Address, @Address1, @MobileNo, @SecMobileNo, @City, @District, @State, @PinCode, @Remark, @UserID)";

then single step and see what happens

btw, not using a try...catch...finally in SaveRecord ? Dangerous

Dave Kreskowiak · Answer 4 · 2020-08-06T05:42:00

<add name="Project1.Properties.Settings.DataFileConnectionString" 

="" connectionstring="Data Source=(LocalDB)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Data\DataFile.mdf;Integrated Security=True" providername="System.Data.SqlClient">

There's an extra ="" in your app.config file. Remove that as it may be screwing with the XML parser for the config file.

Also, the closing tag for the add tag is missing. Add a forward slash to the end of the line, just before the >.

<add name="Project1.Properties.Settings.DataFileConnectionString" 
    connectionstring="Data Source=LocalDB)\MSSQLLocalDB;AttachDbFilename=|DataDirectory|\Data\DataFile.mdf;Integrated Security=True"
    providername="System.Data.SqlClient" />

How to save data in database C# winform

4 solutions

Solution 2

Solution 4

Solution 1

Solution 3

Add your solution here

Preview 0