Regex works in chrome, but breaks in safari: invalid regular expression: invalid group specifier name

Question

0.00/5 (No votes)

See more:

, +

I am trying to print an decimal in JavaScript with commas as thousands separators.

JavaScript

function numberWithCommas(number) {
   return number.toString().replace(/\B(?<!\.\d*)(?=(\d{3})+(?!\d))/g, ",");
}

That regex working good on android, but breaks in iOS (safari, event chrome)

Invalid regular expression: invalid group specifier name

Please help!!

What I have tried:

using old regex instead

JavaScript

function addCommas(nStr) {
         nStr += '';
         var x = nStr.split('.');
         var x1 = x[0];
         var x2 = x.length > 1 ? '.' + x[1] : '';
         var rgx = /(\d+)(\d{3})/;
         while (rgx.test(x1)) {
             x1 = x1.replace(rgx, '$1' + ',' + '$2');
         }
         return x1 + x2;
}

Posted 26-Jul-20 19:50pm

GinCanhViet

Updated 26-Jul-20 20:03pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sandeep Mewara · Accepted Answer · 2020-07-26T20:03:00

Solution 1

Try:
Option 1:

JavaScript

function numberWithCommas(x) {
    return x.toString().replace(/\B(?=(\d{3})+(?!\d))/g, ",");
}

Option 2:
Use Number.prototype.toLocaleString[^].
It was implemented in JavaScript 1.5 (introduced way early in 1999) so should be supported across by all browsers.

JavaScript

var n = 12345678.123
n.toLocaleString() // return "12,345,678.123"

Posted 26-Jul-20 20:03pm

Sandeep Mewara

Updated 26-Jul-20 20:04pm

v2

Comments

GinCanhViet 27-Jul-20 3:02am

This option1 the function adds commas in undesirable places if there are more than 3 digits after the decimal point

Sandeep Mewara 27-Jul-20 3:11am

Try:
function numberWithCommas(n) {
var parts=n.toString().split(".");
return parts[0].replace(/\B(?=(\d{3})+(?!\d))/g, ",") + (parts[1] ? "." + parts[1] : "");
}