How item is checked of checkedboxlist when it is fetch from database

Question

1.00/5 (1 vote)

See more:

how checkedboxitem is selected when it is fetch from database in checkedbox list. what i tried is

What I have tried:

SqlConnection con3 = new SqlConnection(ConfigurationManager.ConnectionStrings["Conec"].ConnectionString);
           SqlCommand cmd3;
           string sql3 = " SELECT Task From Todaywork where Username='" + Login.recuser + "' and Active='1'";
           try
           {
               con3.Open();
               cmd3 = new SqlCommand(sql3, con3);
               string item = cmd3.ExecuteScalar().ToString();
               cmd3.Dispose();
               con3.Close();


               checkedListBoxongoing.SelectedItem = item;





           }
           catch (Exception ex)
           {
               MessageBox.Show(ex.Message);

           }

Posted 15-Jul-20 2:29am

Member 14852747

Updated 15-Jul-20 3:43am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2020-07-15T03:43:00

Your code is vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

You should also wrap your command and connection objects in using blocks to ensure they're always disposed of properly.

And you'll need to deal with cases where your command returns null:

C#

const string sql3 = "SELECT Task FROM Todaywork WHERE Username = @Username AND Active = '1'";

using (SqlConnection con3 = new SqlConnection(ConfigurationManager.ConnectionStrings["Conec"].ConnectionString))
using (SqlCommand cmd3 = new SqlCommand(sql3, con3))
{
    cmd3.Parameters.AddWithValue("@Username", Login.recuser);
    
    con3.Open();
    object result = cmd3.ExecuteScalar();
    if (result != null && !Convert.IsDBNull(result))
    {
        checkedListBoxongoing.SelectedItem = Convert.ToString(result);
    }
}

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]