Which is best static connection or public connection ?

Question

0.00/5 (No votes)

See more:

I work on asp.net core 2.2 I use static SQL connection I already treat with multi database

at run time and exist on multi server so I need to know which is best to my case static

connection or public connection .
when I use connection i create it static I use it as below :

dbConnection = (SqlConnection)InitializeConnection();

suppose Now I need to change connection at run time to get data from another server have another database ?
so Are static connection is good or not ?

What I have tried:

startup.cs

 public void ConfigureServices(IServiceCollection services)
        {
            
          
            services.AddMvc();
       
            GlobalVariables.con = Microsoft
     .Extensions
     .Configuration
     .ConfigurationExtensions
     .GetConnectionString(this.Configuration, "DashBoardSQLConnection");
}

static IDbConnection InitializeConnection()
    {
        switch (_Provider)
        {
            case Providers.SQLServer:
               
                return new SqlConnection(GlobalVariables.con);
             


        }
        return new SqlConnection();
    }

Posted 2-Jun-20 4:41am

ahmed_sa

Updated 2-Jun-20 4:51am

v2

Add a Solution

Comments

Maciej Los 2-Jun-20 10:50am

Best - in what aspect?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2020-06-02T04:53:00

That isn't a static connection - with a static connection there is only one per application, and you don't want that.

What you should be doing is creating your connection, opening it, using it, and disposing of it when you are finished - the easiest way to do that is with a using block:

C#

using (SqlConnection con = new SqlConnection(strConnect)
   {
   con.Open();
   ... use it here ...
   }

The system will then Close and Dispose the connection object for you automatically when it's no longer available. You should also be doing this for SqlCommands, SqlDataReaders, SqlDataAdapters, and so forth.

This prevents some of the nastier problems that crop up later, such as a DataReader being accidentally being left "open" on a connection - which prevents anything else being done with it later.

If you need a connectiuon to another server / DB, you just create that Connection when you needit inside another using block and let the system handle it.