Set items in a empty list

Question

1.00/5 (1 vote)

See more:

Hey I'm making a saving system that saves my 20 client's progress in a json file but the progresses are stored in a list and I'm trying to save them based on the client number

C#

public class User
{
    [JsonProperty("username")]
    public string Username { get; set; }

    [JsonProperty("client-progresses")]
    public int[] ClientProgresses { get; set; }
}

C#

public static void SaveProgress(int progress, int clientNumber)
{
    var user = Program.User;

    user.ClientProgresses[clientNumber] = progress;

    var json = JsonConvert.SerializeObject(user, Formatting.Indented);
    var dir = $"{Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Saves")}";

    if (!Directory.Exists(dir))
    {
        Directory.CreateDirectory(dir);
    }

    dir = Path.Combine(dir, $"{user.Username}.json");

    lock (_fileLocker)
    {
        Task.Delay(100);
        File.WriteAllText(dir, json, new UTF8Encoding(false));
    }
}

The problem is that the list is empty so I can't do

user.ClientProgresses[clientNumber] = progress;

so any ideas how I would set it?

What I have tried:

<pre lang="c#">
    public class User
    {
        [JsonProperty("username")]
        public string Username { get; set; }

        [JsonProperty("client-progresses")]
        public int[] ClientProgresses { get; set; }
    }

C#

public static void SaveProgress(int progress, int clientNumber)
{
    var user = Program.User;

    user.ClientProgresses[clientNumber] = progress;

    var json = JsonConvert.SerializeObject(user, Formatting.Indented);
    var dir = $"{Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Saves")}";

    if (!Directory.Exists(dir))
    {
        Directory.CreateDirectory(dir);
    }

    dir = Path.Combine(dir, $"{user.Username}.json");

    lock (_fileLocker)
    {
        Task.Delay(100);
        File.WriteAllText(dir, json, new UTF8Encoding(false));
    }
}

Posted 7-May-20 7:52am

No bama playz

Updated 16-May-20 5:51am

v3

Add a Solution

Comments

Richard Deeming 18-May-20 12:01pm

Removing the content of your question after it has been answered is extremely rude.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Accepted Answer · 2020-05-07T08:22:00

Try this, and you will see that the value is present:

//using Newtonsoft.Json;
//using System.IO;

var user = new User();
user.Username = "Test1";
user.ClientProgresses = new int[10];
user.ClientProgresses[1] = 1;

var json = JsonConvert.SerializeObject(user, Formatting.Indented);
File.WriteAllText("test.json", json, new UTF8Encoding(false));

AFell2 · Accepted Answer · 2020-05-07T08:33:00

The most important thing you need to do is prepopulate your string array with values. You can do this with the constructor to your class, like so:

public class User
{
    [JsonProperty("username")]
    public string Username { get; set; }

    [JsonProperty("client-progresses")]
    public string[] ClientProgresses { get; set; }

    public User(int customerCount, string defaultState)
    {
        List<string> clientProgresses = new List<string>();

        for (int i = 0; i < customerCount; i++)
        {
            clientProgresses.Add(defaultState);
        }
        
        ClientProgresses = clientProgresses.ToArray();
    }
}

This way, when you construct your user, you pass in both the number of clients you want to initialize, and the default progress state for those clients, like so:

var user = new User(20, "init");

So that when you call your SaveProgress routine, you can test to see if the client exists before you update the value in the array, like so:

if (clientNumber >= user.ClientProgresses.Length)
{
    throw new Exception($"Client number '{clientNumber}' is outside the range of the user client progress array '{user.ClientProgresses.Length}'");
}

Richard Deeming · Accepted Answer · 2020-05-07T09:00:00

Use a dictionary instead of a list or an array:

C#

public class User
{
    [JsonProperty("username")]
    public string Username { get; set; }

    [JsonProperty("client-progresses")]
    public Dictionary<int, int> ClientProgresses { get; set; } = new Dictionary<int, int>();
}

The JSON will look something like:

JavaScript

{
    "username": "...",
    "client-progresses": {
        "42": 10,
        "64": 90
    }
}

Set items in a empty list

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0