C# application design question

Question

5.00/5 (1 vote)

See more:

hello

I'm designing a new employee salary application the requirement is to add multiple employee types in the future and I'm confused if my approach is the right one.

What I have tried:

C#

public interface IEmployee {
        string Name { get; set; }
        decimal CalculateSalary(DateTime from,DateTime to,List<Vacation> vacations);
    }

and the Impelementation to work with sql database goes like this

C#

public class Emp1 : IEmployee {
        public int Id { get; set; }
        public string Name { get; set; }
        public readonly int emptype = 1;
        
    }
    public class Emp2 : IEmployee {
        public int Id { get; set; }
        public string Name { get; set; }
        public readonly int emptype = 2;
        
    }
    public class Vacation {
        public int Id { get; set; }
        public int EmpId { get; set; }
        public int EmpType { get; set; }
        public DateTime Date { get; set; }
        public string Reason { get; set; }
        
    }

I had gone with such implementation because each employee is very different from the others but vacations are the same for them all.
is there a better approach?
I'm also confused how am I supposed to validate employee name none repeating

Posted 2-May-20 2:34am

M. Rawan

Updated 2-May-20 2:49am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Accepted Answer · 2020-05-02T02:51:00

Your approach looks ok to me, however when your application gets bigger and more complex you might be interested in implementing the Factory pattern:
https://dzone.com/articles/design-patterns-c-factory[^]
C# Design Patterns - Factory Method - Code Maze[^]

Sometimes creating an (UML) diagram can help, see: How do I design an employee manager relationship class diagram[^]

To validate the employee name you can use a UNIQUE constraint in your database, or if you prefer a C# solution you could use a dictionary, see: Dictionary<TKey,TValue> Class (System.Collections.Generic) | Microsoft Docs[^]

If your database needs are simple I would recommend LiteDB, see: best-databases-for-a-small-net-application[^]

If you want to use SQL Server (warning not the easiest option) take a look at: Querying SQL Server Tables from .NET[^]

If you want a database independent solution then you can use an ORM, see: orms-for-c[^]

To learn about database design, see: online-resources-to-learn-relational-database-design[^]