The conversion of a varchar data type to a datetime data type resulted in an out-of-range value. The statement has been terminated.

Question

1.00/5 (1 vote)

See more:

The conversion of a varchar data type to a datetime data type resulted in an out-of-range value.

The statement has been terminated.

my c# code.

string str = "insert into TblStock1 values('" + textBox1.Text + "','" + textBox2.Text + "','" + dateTimePicker1.Value.ToString("dd/MM/yyyy") + "','" + textBox3.Text + "','" + comboBox1.Text + "')";

What I have tried:

my c# code.
<pre>string str = "insert into TblStock1 values('" + textBox1.Text + "','" + textBox2.Text + "','" + dateTimePicker1.Value.ToString("dd/MM/yyyy") + "','" + textBox3.Text + "','" + comboBox1.Text + "')";

Posted 17-Apr-20 12:53pm

Member 11297177

Updated 17-Apr-20 13:45pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

MadMyche · Accepted Answer · 2020-04-17T13:46:00

Your C# code is a candidate for SQL Injection. You should NEVER EVER put together an SQL Command by concatenating command text with user input.

What you should be doing is using parameters for this, which will give you something like this

C#

string qry = "INSERT INTO TblStock1 VALUES (@txt1, @txt2, @dt1, @tx3, @cb1)";

SqlCommand = new SqlCommand(qry, connectionstring);
    cmd.Parameters.AddWithValue("@txt1", textBox1.Text);
    cmd.Paramaters.AddWithValue("@txt2", textBox2.Text);
//  cmd.Paramaters.AddWithValue("@dt1",  ** later **);
    cmd.Paramaters.AddWithValue("@txt3", textBox3.Text);
    cmd.Paramaters.AddWithValue("@cb1", comboBox1.Text);

Now onto your problem with the conversion...

Leave DateTime values as DateTime; they are numerical in nature and the only time formatting comes into play is when you are showing it to an end-user.
So the commented out line above should just be replaced with

C#

cmd.Paramaters.AddWithValue("@dt1", dateTimePicker1.Value );