LINQ query with where condition

Question

0.00/5 (No votes)

See more:

i have select in linq and in where condition i am checking two times remarks. Is there way to optimize instead of having andalso condition.

dim List = (From c In db.DevData
                     Where c.remark <> "Cancelled" AndAlso c.remark <> "Completed"
                     Order By c.Id

What I have tried:

dim List = (From c In db.DevData
                     Where c.remark <> "Cancelled" AndAlso c.remark <> "Completed"
                     Order By c.Id

Posted 7-Apr-20 2:19am

Chinnu2020

Updated 7-Apr-20 3:32am

Add a Solution

Comments

Maciej Los 7-Apr-20 8:23am

What you mean by "optimize", in what context?

Note, taht we don't see you screen and can't read in your mind. Can you be more specific?

Chinnu2020 7-Apr-20 8:41am

Instead of writing c.remark two times can it be done in single way?

Maciej Los 7-Apr-20 9:20am

If you would like to be sure that system will inform me about your replies, please use "Reply" widget. You'll find it near to the nick (login) - on the right side.

As i mentioned, you need to be more specific. I have no idea how your database is designed, how many remarks is in there, and why do you use <> operator instead of = (equal).

Chinnu2020 24-Apr-20 13:43pm

dim List = (From c In db.DevData
Where c.remark <> "Cancelled" AndAlso c.remark <> "Completed"
Order By c.Id

when remark is null in database those records are not fetching. is there issue with above query?

Maciej Los 24-Apr-20 14:00pm

dim List = (From c In db.DevData
Where c.remark IsNot Nothing AndAlso c.remark <> "Cancelled" AndAlso c.remark <> "Completed"
Order By c.Id

Chinnu2020 24-Apr-20 14:31pm

even though remarks which is null is not display

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

F-ES Sitecore · Answer 1 · 2020-04-07T02:43:00

Put your statuses ("Completed", "Cancelled" etc) in their own table with their own IDs and store the ID in your DevData column instead, so if Completed is 1 have a StatusID with a value of 1 in DevData. Now you can do your wheres using numbers rather than text, or you can join DevData with the Status table and say where Status.Name <> "Completed" etc and that should perform much better.

Maciej Los · Answer 2 · 2020-04-07T03:32:00

Solution 2

Please, read my comments to your question first.

You can use Where + Any[^], but i doubt it would improve, or even optimize, the performance of your query.

VB.NET

Dim remarks = {"Cancelled", "Completed"}
Dim list = from c in db.DevData.Where(Function(x) remarks.Any(Function(y) x.remark<>y))
           Order By c.Id
           Select ...

Posted 7-Apr-20 3:32am

Maciej Los

Comments

Chinnu2020 8-Apr-20 6:58am

i tried with above code its is giving as lamda expression cannot be converted to Boolean because Boolean is not delegate type