How to pass where clause as a parameter to the stored procedure?

Question

0.00/5 (No votes)

See more:

CREATE PROCEDURE sp_MasterCountry (IN whereData longtext)
begin
declare sqlQuery longtext;
set sqlQuery="Select * from CountryMaster_tb" + whereData ;

call sqlQuery;

end;

I Need to Pass full where clause from my page because some time ill pass by Country_Name and sometime ill pass just short name of Country_Name using like

What I have tried:

CREATE PROCEDURE sp_MasterCountry (IN whereData longtext)
begin
declare sqlQuery longtext;
set sqlQuery="Select * from CountryMaster_tb" + whereData ;
 
call sqlQuery;
 
end;

giving me error

in MYSQL Server
I am using MYSQL Workbench for GUI

Posted 6-Apr-20 1:40am

hareshdgr8

Updated 6-Apr-20 1:46am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-04-06T01:47:00

Spaces are important.
Try changing this:

SQL

set sqlQuery="Select * from CountryMaster_tb" + whereData ;

To this:

SQL

set sqlQuery="Select * from CountryMaster_tb " + whereData ;

But ... be aware that that is very dangerous.
You shouldnNever concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'

The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'

Which SQL sees as three separate commands:

SQL

SELECT * FROM MyTable WHERE StreetAddress = 'x';

A perfectly valid SELECT

SQL

DROP TABLE MyTable;

A perfectly valid "delete the table" command

SQL

--'

And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?

In this case, you probably want to make the SP more intelligent and pass optional parameters to it that let it select which WHERE clause to use instead of passing a string containing "WHERE ..." at all.