Asp.net custom session state provider event calling multiple times

Question

0.00/5 (No votes)

See more:

Below events calling multiple times:

C#

public override SessionStateStoreData GetItemExclusive(HttpContext context, string id, out bool locked, out TimeSpan lockAge, out object lockId, out SessionStateActions actionFlags) 
{
    return GetSessionStoreItem(true, context, id, out locked, out lockAge, out lockId, out actionFlags); 
}

public override void ReleaseItemExclusive(HttpContext context, string id, object lockId) {
    string tmpQuery = @"UPDATE Sessions SET Locked = 0, Expires = @expires@ WHERE SessionId = '@sess_id@' AND ApplicationName = '@app_name@' AND LockId = '@lock_id@'";

    tmpQuery = tmpQuery.Replace("@expires@", convDate_forQuery(DateTime.Now.AddMinutes((double)(pConfig.Timeout.Minutes))));
    tmpQuery = tmpQuery.Replace("@sess_id@", id);
    tmpQuery = tmpQuery.Replace("@app_name@", ApplicationName);
    tmpQuery = tmpQuery.Replace("@lock_id@", lockId.ToString());

    try
    {
        SessDataAccess.ExecuteNQ(tmpQuery);
    }
    catch (Exception e)
    {
        if (WriteExceptionsToEventLog)
        {
            WriteToEventLog(e, "ReleaseItemExclusive");
            throw (e);
        }
        else
            throw e;
    }
}

Events log:

2/20/2020 1:40:43 PM:GetItemExclusive
2/20/2020 1:40:43 PM:GetItemExclusive
2/20/2020 1:40:43 PM:GetItemExclusive
2/20/2020 1:40:43 PM:GetItemExclusive
2/20/2020 1:40:43 PM:GetItemExclusive
20-02-2020 13:40:43:Initialize
2/20/2020 1:40:43 PM:GetItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive
2/20/2020 1:40:43 PM:ReleaseItemExclusive

Can anyone help me on this! thanks in advance.

What I have tried:

I tried to kept logs, how many times it calling

Posted 19-Feb-20 21:30pm

sreeharijakkala

Updated 20-Feb-20 2:27am

Richard Deeming

v2

Add a Solution

Comments

Richard Deeming 20-Feb-20 8:27am

tmpQuery = tmpQuery.Replace("@expires@", convDate_forQuery(DateTime.Now.AddMinutes((double)(pConfig.Timeout.Minutes))));

Don't do it like that!

Your code is almost certainly vulnerable to SQL Injection[^]. NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

You need to update your SessDataAccess class so that it doesn't force you to inject parameter values directly into the query.

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)