How do I get multiple images from SQL database and display in autocreated picturebox...

Question

0.00/5 (No votes)

See more:

i need to get multiple image from sql server database and display it by auto created picturebox inside the flowlayout panel.but it displays the same image from first row of the table.

What I have tried:

C#

while (flowLayoutPanel.Controls.Count > 0)
            {
                flowLayoutPanel.Controls[0].Dispose();
            }
                con = new SqlConnection(@"Data Source=(local);Initial Catalog=hotel_manage;Integrated Security=True");
                con.Open();
                SqlCommand cmd = new SqlCommand("select * from item where cat_id=5", con);
                SqlDataAdapter da = new SqlDataAdapter(cmd);
                DataTable dt = new DataTable();
                da.Fill(dt);
                for (int i = 0; i < dt.Rows.Count;++i)
                {
                    PictureBox pic = new PictureBox();
                        con.Open();
                        SqlCommand cmmd = new SqlCommand("select image from item where cat_id=5", con);
                        Byte[] bytes = (Byte[])cmmd.ExecuteScalar();
                        MemoryStream ms = new MemoryStream(bytes);
                        pic.Image = Image.FromStream(ms);
                        pic.SizeMode = PictureBoxSizeMode.AutoSize;
                        this.flowLayoutPanel.Controls.Add(pic);
                }
        }

Posted 5-Jan-20 22:46pm

Fahad Roger

Updated 5-Jan-20 23:02pm

CHill60

v3

Add a Solution

2 solutions

Solution 1

You only ever retrieve one item from the database

C#

SqlCommand cmmd = new SqlCommand("select image from item where cat_id=5", con);

I think you need to remove the where clause from the Fill and then use the cat_id for each row as a parameter for the cmmd command

Posted 5-Jan-20 22:58pm

CHill60

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2020-01-05T23:02:00

Well yes. That because you ask for the same image every time you go round the loop:

C#

SqlCommand cmmd = new SqlCommand("select image from item where cat_id=5", con);

If you replace the "5" with the value from your loop, then it will return different images.

But ... you have already retrieved all the images and they are in your DataTable - so why not use the values directly from there?

C#

byte[] bytes = (byte[]) dt.Rows[i]["image"];

And I'd use a foreach on the Rows instead of a for loop.