Nested if statement in Python

Question

0.00/5 (No votes)

See more:

I cannot get the second if statement in my code to return what I want which is [current date '11:00:00'].
It only returns [current date '09:00:00']

What I have tried:

Python

def today_hours():
    today_date = []
    today_date.append(return_week_day()[0:10])
    for key, value in hourly_dates.items():
        if key in first_indices:
            if value == True:
                today_date.append(return_week_day()[11:19])
            else:
                if value == morning_hours:
                    today_date.append('09:00:00')
                else:
                    if value == noon_hours:
                        today_date.append('11:00:00')
            return today_date

print(today_hours())

Posted 17-Jul-19 11:08am

Member 13949923

Updated 17-Jul-19 11:26am

Patrice T

v2

Add a Solution

Comments

Richard MacCutchan 18-Jul-19 3:35am

You are trying to use the variable value to represent different types:True, morning_hours and noon_hours, so the if statements will be confused.

Member 13949923 18-Jul-19 6:48am

I think u might be on to something here but I don't fully get it. Would be kind and reformulate what u mean?

Richard MacCutchan 18-Jul-19 8:19am


for key, value in hourly_dates.items():

What is returned in the variable named value?

Member 13949923 19-Jul-19 7:34am

hourly_dates = {'morning': morning_hours, 'noon': noon_hours, 'afternoon': afternoon_hours, 'evening': evening_hours, 'night': night_hours}

If the there is an input such a 'Today evening' and the datetime is in the 'evening' parameter(between 18:00:00 - 21:00:00) it returns 'True' and then prints [current date '19:00:00'] but if input is 'Today morning' it should get 'False' for the first if statement 'Value == True' and then move to second if statement (Value == 'morning_hours') after else statement and so on. But when I input 'Today noon' it does not move to next if statement that has the 'Value == noon_hours'. It just keep printing if statement of 'morning_hours' and don't move the next statement.

Richard MacCutchan 19-Jul-19 8:12am

You cannot compare value to True or False, since it will contain one of the values in the hourly_dates list.

Richard MacCutchan 19-Jul-19 10:46am

Since we cannot see the data you are working with it is impossible to answer. Use the debugger to step through the code and see exactly what you are comparing at each if statement. For example what is in the variables key and first_indices, at the beginning.

Member 13949923 19-Jul-19 10:45am

thank you so much for all the help, solved it now.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2019-07-17T11:27:00

For comments on your code, you need to include the variables it use.

Quote:
I cannot get the second if statement in my code to return what I want which is [current date '11:00:00'].
It only returns [current date '09:00:00']

Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

27.3. pdb — The Python Debugger — Python 3.6.1 documentation[^]
Debugging in Python | Python Conquers The Universe[^]
pdb – Interactive Debugger - Python Module of the Week[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.