Onclick not working in firefox

Question

5.00/5 (1 vote)

See more:

Hi all i have a small coding to copy the uploaded file path to a textbox using javascript. Its working fine in IE but onclick not firing in firefox.

HTML

<html>
<body>

<form method="post" action="<?php echo($_SERVER['PHP_SELF']);?>" name="form1" >
<label for="file">Filename:</label>
<input type="file" name="file1" id="file" ><br>
<input type="text" name="txtH" id="txtH"/>
<input type="button" name="submit" value="Submit" id="btnSubmit" onclick="fun()">

<script type="text/javascript">
function fun()
{
	document.getElementById('txtH').value=document.getElementById('file1').value;
	alert("hai");
}


</script>
</form>

</body>
</html>

Posted 2-Dec-12 18:53pm

Member 9650694

Add a Solution

Comments

Peter_in_2780 3-Dec-12 2:43am

Your element <input type="file" name="file1" id="file" > has an id of file, but your JS is looking for an id of file1
If that is really your code, then it shouldn't work in ANY browser.
So what is your code, really?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2012-12-02T19:54:00

Solution 1

You have error in this line...

JavaScript

document.getElementById('txtH').value = document.getElementById('file1').value;

You are accessing the File Uploader's path by getElementById('file1'), but the id is not 'file1', it is 'file' as per below...

XML

<input type="file" name="file1" id="file"></input>

Change the function to the below code, it will work.

JavaScript

function fun()
{
    document.getElementById('txtH').value=document.getElementById('file').value;
    alert("hai");
}

Posted 2-Dec-12 19:54pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Comments

Member 9650694 3-Dec-12 2:01am

yes thank you but i am not getting full path of the file only getting file name in firefox. How to solve this? Pls help

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 2:16am

Ok let me work this out... I will come back with the reply.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 2:16am

Thanks for accepting the answer.

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 2:33am

Actually you can't get the full file path as it is a security risk.
But this code gives the full path in IE browsers.
Check the below links for more details.
1. How to get full path from file upload box in javascript?
2. How to get the complete file path in Mozila

Thanks,
Tadit

Member 9650694 3-Dec-12 4:16am

Thanks is there any other way or can we use any other control to get the full path?

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 4:52am

You can do it by replacing the file upload control by one textbox and one browse button, but that is also one security risk (not recommended).

Can you please explain why you exactly want to get the full file path from client's machine ?

Member 9650694 3-Dec-12 4:55am

Actually i need to upload a mdb file have to do insertion and deletion.
The file may be anywhere in the local disk so i have to give the full path of the file to insert or delete

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 5:27am

It is fine, but the why the full path is needed ?
In general, we only store the name of the file in DataBase and save that in some folder in server and do any task on that.

Member 9650694 3-Dec-12 6:47am

No even for copy that file from local drive i need full path

sunandandutt 3-Dec-12 2:11am

My 5!

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 3-Dec-12 2:14am

Thanks @sunandandutt...

sunandandutt 3-Dec-12 6:08am

Welcome!