Click here to Skip to main content
15,913,115 members
Please Sign up or sign in to vote.
2.00/5 (1 vote)
See more:
Hi,
Please let me know how to update values in new.aspx page after redirecting from first.aspx page, i tried in the following code but am unable to update the values only the prevoius values is appearing after the changes made.

C#
protected void Button3_Click(object sender, EventArgs e)

    {
        string EmpNo = TextBox1.Text;
        string EmpName = TextBox2.Text;
        string Designation = DropDownList1.SelectedItem.Text;
        string Department = DropDownList2.SelectedItem.Text;
        decimal Salary = Convert.ToDecimal(TextBox3.Text);

                if (!string.IsNullOrEmpty(Request.QueryString["EmpNo"]))
        {
            EmpNo = Request.QueryString["EmpNo"].ToString();

            
            SqlConnection con = new SqlConnection("Server=TCT-SW24;uid=sa;password=******; database=sreeramdasari;");
            
            String query = string.Empty;
            query = string.Format("update EmployeeDetails set EmpName='{1}', Designation='{2}',Department='{3}',Salary='{4}' where EmpNo='{0}'", EmpNo, EmpName, Designation, Department, Salary, con);
            //query = string.Format(("Update EmployeeDetails set EmpName=@EmpName, Designation=@Designation,Department=@Department,Salary=@Salary where EmpNo=@EmpNo"), con);
            //query = string.Format("Update EmployeeDetails set EmpName={1}, Designation={2},Department={3},Salary={4} where EmpNo={0}", EmpNo, EmpName, Designation, Department, Salary, con);
            SqlCommand cmd = new SqlCommand(query, con);
            cmd.CommandType = CommandType.Text;



            cmd.Parameters.AddWithValue("@EmpNo", EmpNo);
            cmd.Parameters.AddWithValue("@EmpName", EmpName);
            cmd.Parameters.AddWithValue("@Designation", Designation);
            cmd.Parameters.AddWithValue("@Department", Department);
            cmd.Parameters.AddWithValue("@Salary", Salary);
            cmd.Connection = con;
            con.Open();
            cmd.ExecuteNonQuery();
            Label6.Text = (" Record Updated Successfully");
            Label6.Enabled = true;
            TextBox1.Enabled = false;
            con.Close();
        }
    }

Thanks&Regards
Sreeraam_d
Posted
Updated 7-Nov-12 19:58pm
v2

1 solution

Your code is totally wrong.There may be SQL attack in your query.Beware.
May be following snippet help you.
C#
protected void Button3_Click(object sender, EventArgs e)
 
    {
        string EmpNo = TextBox1.Text;
        string EmpName = TextBox2.Text;
        string Designation = DropDownList1.SelectedItem.Text;
        string Department = DropDownList2.SelectedItem.Text;
        decimal Salary = Convert.ToDecimal(TextBox3.Text);
 
                if (!string.IsNullOrEmpty(Request.QueryString["EmpNo"]))
        {
            EmpNo = Request.QueryString["EmpNo"].ToString();
 
            
            SqlConnection con = new SqlConnection("Server=TCT-SW24;uid=sa;password=******; database=sreeramdasari;");
            
            String query = string.Empty;
            query = string.Format(("Update EmployeeDetails set EmpName=@EmpName, Designation=@Designation,Department=@Department,Salary=@Salary where EmpNo=@EmpNo"), con);
           
            SqlCommand cmd = new SqlCommand(query, con);
            cmd.CommandType = CommandType.Text;
 

 
            cmd.Parameters.AddWithValue("@EmpNo", EmpNo);
            cmd.Parameters.AddWithValue("@EmpName", EmpName);
            cmd.Parameters.AddWithValue("@Designation", Designation);
            cmd.Parameters.AddWithValue("@Department", Department);
            cmd.Parameters.AddWithValue("@Salary", Salary);
            cmd.Connection = con;
            con.Open();
            cmd.ExecuteNonQuery();
            Label6.Text = (" Record Updated Successfully");
            Label6.Enabled = true;
            TextBox1.Enabled = false;
            con.Close();
        }
    }
 
Share this answer
 
Comments
Sreeraam_d 8-Nov-12 2:18am    
Even though it is not updating, should i write any code for update on page load?

please correct the following page load code.

protected void Page_Load(object sender, EventArgs e)
{

if (!Page.IsPostBack)
{
DropDownList1.Items.Add("Manager");
DropDownList1.Items.Add("Assistant Manager");
DropDownList1.Items.Add("Sales Rep");

DropDownList2.Items.Add("Accounts");
DropDownList2.Items.Add("Sales");
}

string EmpNo = string.Empty;




if (!string.IsNullOrEmpty(Request.QueryString["EmpNo"]))
////if (Request.QueryString["EmpNo"]!= null)
{
EmpNo = Request.QueryString["EmpNo"].ToString();

// TextBox2.Text = "";
// DropDownList1.SelectedItem.Text = "";
// DropDownList2.SelectedItem.Text = "";
// TextBox3.Text = "";


SqlConnection con = new SqlConnection("Server=TCT-SW24;uid=sa;password=**********; database=sreeramdasari;");
SqlCommand cmd = new SqlCommand("select* from EmployeeDetails where EmpNo='" + EmpNo + "'", con);


//SqlCommand cmd = new SqlCommand("MyProcedure1", con);
//cmd.CommandType = CommandType.StoredProcedure;
con.Open();
cmd.Parameters.AddWithValue("@EmpNo", EmpNo);
SqlDataReader sdr = cmd.ExecuteReader();

if (sdr.Read())
{
TextBox1.Text = EmpNo;
TextBox2.Text = sdr[1].ToString();
DropDownList1.SelectedValue = sdr[2].ToString().Trim();
DropDownList2.SelectedValue = sdr[3].ToString().Trim();
TextBox3.Text = sdr[4].ToString();

}

TextBox1.Enabled = false;
Button1.Enabled = false;
Button2.Enabled = true;
Button3.Enabled = true;
Button4.Enabled = true;
con.Close();




}

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900