C# & SQL problem

Question

0.00/5 (No votes)

See more:

Hi,

I get this error every time I try to change the dropdownlist1 index value which are only two values, sale and rent; "incorrect syntax near '='"

Could someone help me please?
-------------------

string select;
        select = "SELECT * FROM Property";
        select += "WHERE Sale_Rent='" + DropDownList1.SelectedItem.Value.ToString() + "'";
        SqlConnection connect1 = new SqlConnection(connectionString);

        SqlCommand myCommand = new SqlCommand(select, connect1);

       
        SqlDataReader readIt;

        try
        {
            connect1.Open();//make connection

            readIt = myCommand.ExecuteReader();

            while (readIt.Read())
            {
                ListItem newItem = new ListItem();
                newItem.Text = readIt["Address"].ToString();
                newItem.Value = readIt["Property_ID"].ToString();
                box1.Items.Add(newItem);
            }
            readIt.Close();
        }

Posted 25-Dec-09 20:24pm

techy_00

Add a Solution

4 solutions

Solution 2

There is no space between Property and Where in your SQL statement. That must be causing the error.

Posted 25-Dec-09 22:23pm

dan!sh

Solution 4

Thanks for all your replies, appreciated.

:)

Posted 26-Dec-09 20:57pm

techy_00

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2009-12-25T22:50:00

The syntax error is because you need a space between "Property" and "WHERE" - at the moment your select statement evaluates to:

"SELECT * FROM PropertyWHERE Sale_Rent='Rent'"

In addition:
1) Tag your question with ASP.NET, rather than C# - a DropDownList with a Value property does not exist outside ASP.NET.
2) Try to get into the habit of using parameterized queries: I know that your existing code has no risk of an SQL Injection attack, but when you re-use this code in a month for you text box, you won't think about it. It is well worth getting into the habit early, and using it at all times.
3) Why didn't you try using the debugger? That would have shown you the problem in thirty seconds!

veenag81 · Accepted Answer · 2009-12-25T22:01:00

Solution 1

Hello,
select += "WHERE Sale_Rent='" + DropDownList1.SelectedItem.Value.ToString() + "'";

change of above line as

select += "WHERE Sale_Rent='" + DropDownList1.SelectedValue.ToString() + "'";

Posted 25-Dec-09 22:01pm

veenag81