outofmemoryexception due to nested for loops

Question

0.00/5 (No votes)

See more:

Hi friends i am getting outofmemoryexception, Here is my code which is in italic i have to optimized these nested loops to avoid the exception.

I am telling the background here ,I have a condition in which i have Dataset A,Dataset B and Dataset C.Dataset A is parent & the remaing are childs,I have to merge Dataset B & dataset C in Dataset A wrt loanmasterid.

case Constants.Reports.UHrptLoanSummarybatch:
                  rptData = dbHelper.Get_Loan_Summary_Batch(objReportHelper.CustomerId, objReportHelper.AuditId);//  parent  table
                  rptData2 = dbHelper.Get_Other_Comments_Batch(objReportHelper.CustomerId, objReportHelper.AuditId);
                  rptData4 = dbHelper.Get_Audit_Details_Batch(objReportHelper.CustomerId, objReportHelper.AuditId);

                  rptData.DataSetName = "spReport_LoanSummaryBatch_edit";

                  foreach (DataColumn col in rptData2.Tables[0].Columns)
                  {
                      if(!rptData.Tables[0].Columns.Contains(col.ColumnName))
                          rptData.Tables[0].Columns.Add(col.ColumnName);
                  }

                  foreach (DataColumn col in rptData4.Tables[0].Columns)
                  {
                      if(!rptData.Tables[0].Columns.Contains(col.ColumnName))
                          rptData.Tables[0].Columns.Add(col.ColumnName);
                  }

                  DataRow [] dRows;
                  DataRow parentRow;
                  DataRow newRow;

                  //for (int i = 0; i < rptData.Tables[0].Rows.Count; i++)
                  //{
                  //    parentRow = rptData.Tables[0].Rows[i];

                  //    dRows = rptData2.Tables[0].Select("loanmasterid=" + parentRow["loanmasterid"].ToString());

                  //    foreach (DataRow childRow in dRows)
                  //    {
                  //        newRow = rptData.Tables[0].NewRow();

                  //        foreach (DataColumn childCOl in rptData2.Tables[0].Columns)
                  //        {
                  //            newRow[childCOl.ColumnName] = childRow[childCOl.ColumnName];
                  //        }

                  //        rptData.Tables[0].Rows.Add(newRow);

                  //    }
                  //}

                  for (int i = 0; i < rptData.Tables[0].Rows.Count; i++)
                  {
                      parentRow = rptData.Tables[0].Rows[i];

                      dRows = rptData4.Tables[0].Select("loanmasterid=" + parentRow["loanmasterid"].ToString());

                      foreach (DataRow childRow in dRows)
                      {
                         newRow = rptData.Tables[0].NewRow();

                          foreach (DataColumn childCOl in rptData4.Tables[0].Columns)
                          {
                              newRow[childCOl.ColumnName] = childRow[childCOl.ColumnName];
                          }

                          rptData.Tables[0].Rows.Add(newRow);

                      }
                  }






                  objReportDataSource = new ReportDataSource("spReport_LoanSummaryBatch_edit", rptData4.Tables[0]);



                  objReportDataSource4 = new ReportDataSource("spReport_LoanSummaryBatch_edit", rptData4.Tables[0]);





                  ReportViewer1.LocalReport.ReportPath = "Reports/UHrptLoanSummarybatch.rdlc";

                  break;

Posted 3-Nov-12 11:09am

Ali_100

Updated 3-Nov-12 11:13am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2012-11-03T21:11:00

Um. I'm not surprised.

Your code is effectively

C#

int j = 2;
for (int i = 0; i < j; i++)
   {
   j++;
   }

because inside your for loop you add a variable number of rows to rptData.Tables[0] and then use the number of rows in the table to control the loop. So if you ever get to the position where a row causes a copy of itself to be added to the table, then it will start an infinite loop, and you will run out of memory because you create new objects each time round.

I don't know what you are trying to do, but I can't help thinking that you are going about it the wrong way!