dynamic adding form controls

Question

1.00/5 (2 votes)

See more:

i type the code below, but i only see one button in form with 100 left.

C#

private void Form1_Load(object sender, EventArgs e)
        {            
            Button[] btnexit = new Button[5];
            for (int i = 1; i <= 5; i++)
            {
                btnexit[i] = new Button();
                this.Controls.Add(btnexit[i]);
                this.Text = this.Text + i.ToString();                
            }
            btnexit[1].Left = 100;
            btnexit[2].Left = 200;
            btnexit[3].Left = 300;
            btnexit[4].Left = 400;
        }

i couldn't solve it. what is, it's solution?

Posted 18-Jun-12 4:11am

mrmarzban

Add a Solution

2 solutions

Solution 2

Both code in the question and the answer by Mantu are wrong. It should be something like that:

C#

int buttonCount = 5;
Button[] buttons = new Button[buttonCount];

//...

int gap = 10; //... some suitable gap between buttons
int currentX = //... some starting position
for (int index = 0; index < buttonCount; ++index) {
    Button button = new Button();
    button.Text = //... and not this.Text, why?
    button.Top = //...  
    button.Left = currentX + gap;
    buttons[index] = button;
    this.Controls.Add(button);
    currentX += this.Width;
}

This way, you can arrange those buttons by X taking into account their actual width when the text is already set up. Also, pay attention that I did not repeat your "5" anywhere, which would be a deadly sin of programming.

—SA

Posted 18-Jun-12 8:05am

Sergey Alexandrovich Kryukov

Updated 18-Jun-12 8:52am

v3

Comments

Sandeep Mewara 18-Jun-12 14:48pm

Correct. A 5!

Sergey Alexandrovich Kryukov 18-Jun-12 14:50pm

Thank you, Sandeep.
--SA

mrmarzban 19-Jun-12 0:47am

i used "5" just as a number, that wasn't a part of my program.
i used "this", just to see that my "for" is working.
how ever your solution helped me to solve my problem better.
thanks for that.

Sergey Alexandrovich Kryukov 29-Jun-12 22:24pm

If so, please accept the answer formally (green button) -- thanks.
--SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mantu Singh · Accepted Answer · 2012-06-18T04:47:00

Solution 1

The above code gives index out of bound exception just alittle correction and it works as below:-

C#

Button[] btnexit = new Button[5];
           for (int i = 0; i < 5; i++)
           {
               btnexit[i] = new Button();
               this.Controls.Add(btnexit[i]);
               this.Text = this.Text + i.ToString();
           }
           btnexit[1].Left = 100;
           btnexit[2].Left = 200;
           btnexit[3].Left = 300;
           btnexit[4].Left = 400;

Best of luck!!

Posted 18-Jun-12 4:47am

Mantu Singh

Comments

Sergey Alexandrovich Kryukov 18-Jun-12 14:07pm

Very bad; you repeated two mistakes of OP, to say the least...
--SA

Mantu Singh 19-Jun-12 14:57pm

thanks a lot sir for reminding the mistake but I only wanted to run the code and see if i would be able to help and i found index out of range exception on first run.........