Adding LogService to my Application

Question

0.00/5 (No votes)

See more:

, +

I have an application (Legacy code)

that contains interface `Icomponent` with `save()` methods

and many classes that implement it.

I want to add log after every save().

I thought to

use the decorator pattern to `Icomponent` with additional `log()` method.

create `LogService` class which is called from each decorator's `log()`

I think `LogService` is a classic case of singelton, but I read it would be hard for unit-testing.

What would be you design to that solution?

Posted 9-May-12 10:19am

elad2109

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2012-05-09T10:43:00

First of all, look at Apache log4net: http://logging.apache.org/log4net/[^].

I think decoration components with logging is too heavy weight and too much if stiff coupling. I would allow it for an optional feature where logging is often of always useful. In general case, this is no good.

The use of singleton if way more adequate. I would agree that this would be a classic case of singleton usage. "Hard for unit testing?" Hm. I suspect this is just a result of a sick fantasy of some person who does not actually do unit testing. I don't see any specific problems for unit testing here. I can imagine that I'm missing something though. In this case, let this person write to me and explain where is that hardness; I would greatly appreciate it.

—SA

Sandeep Mewara · Answer 2 · 2012-05-09T19:33:00

Solution 2

Try:
Microsoft's Enterprise Library - Logging Application Block[^]
Get Logging with the Enterprise Library[^]

Posted 9-May-12 19:33pm

Sandeep Mewara