C# Calculator test - need help (basic)

Question

0.00/5 (No votes)

See more:

I have a test calculator - It's setup with 2 textboxes (the main one and a side one)
the main one is where it shows the users input for the first number (string number1 - yes sring ill convert it later) and then when the users selects a tool like Add, Subtract, Divide or Multiply, number1 travels to the smaller textbox and textBox1 clears so the user enters the main box while their first input stays in the small textBox2. (ask questions if im unclear)

basically when they select Add (or another tool) the number1 travels to textbox2 but textbox1 does not write number2 which the user enters

ill include some sample code:

C#

static public string number1 = String.Empty;
        static public string number2 = String.Empty; //declare empty strings
        static public string spare = String.Empty;

             //this adds 6 to the string number1 or number2 
        private void button6_Click(object sender, EventArgs e) //add 6 to string
        {
            if (num1)
            {
                number1 = number1 + "6";
                textBox1.Text = number1; 
            }
            if (!num1)
            {
                number2 = number2 + "6";
                textBox1.Text = number2;
            }
        }

//this is the Add button which sends number1 to spare & to textbox2
//then writes number2 into textBox1 for the user to intput numbers in

C#

private void button12_Click(object sender, EventArgs e) //add
        {
            add = true;
            spare = number1;
            number1 = String.Empty;
            textBox2.Text = spare;
            textBox1.Text = number2;
            num1 = false;
            num2 = true;
        }

but textBox1 doesnt write number2 when they enter it, it just stays blank
why?

Posted 27-Dec-11 1:51am

Joel Whatley-

Updated 27-Dec-11 1:52am

uspatel

v2

Add a Solution

Comments

uspatel 27-Dec-11 7:53am

EDIT: pre tag added.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-12-27T02:07:00

This is going to sound a little strange, but try dropping the concept of "number1" and "number2".

Instead, use Textbox1.Text as your "current input string area" and add to it in your button click event:

C#

private void button6_Click(object sender, EventArgs e) //add 6 to string
    {
    textBox1.Text += "6";
    }

Copy from TextBox1.Text to TextBox2.Text directly and ignore num1, num2 number1 and number2 completely.

In addition, I would make a small change:
Every control has a Tag property. For each of your number buttons, make the Tag that character.
1 button -> Tag == "1"
2 button -> Tag == "2"
...
Then have a single handler routine for all number buttons:

C#

private void NumberButton_Click(object sender, EventArgs e) //add 6 to string
    {
    Button b = sender as Button;
    if( b != null)
        {
        textBox1.Text += (string) b.Tag;
        }
    }

This way, you don't have to change the code in ten different places to alter your button handling.

And pretty please, don't use the Visual studio default names for things! button12 is not as obvious as butAdd when you come back to the code next week, and it can save a lot of time trying to work out which button does what.

[edit]Typos - OriginalGriff[/edit]

nishantcomp2512 · Answer 2 · 2011-12-27T02:17:00

C#

//add multiply or division etc click
private void button6_Click(object sender, EventArgs e) //add 6 to string
{
    if(textBox1.Text != string.Empty && textBox2.Text!=string.Empty)
    {
       switch(((Button)sender).Text)
       {
       case "+":
            textBox1.Text=""+(Covert.toDouble(textBox1.Text) +  Covert.toDouble(textBox2.Text));
            break;
        case "-":
            textBox1.Text=""+(Covert.toDouble(textBox1.Text) -  Covert.toDouble(textBox2.Text));
            break;
        case "/":
            textBox1.Text=""+(Covert.toDouble(textBox1.Text) /  Covert.toDouble(textBox2.Text));
            break;
        case "X":
            textBox1.Text=""+(Covert.toDouble(textBox1.Text) *  Covert.toDouble(textBox2.Text));
            break;
       }

    }
    else if(textBox2.Text==string.Empty && textBox1.Text != string.Empty)
    {
       textBox2.Text = textBox1.Text;
    }
 }

you can add case for add multiply or division or ..

regards,

C# Calculator test - need help (basic)

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0