Where to update toolbar's buttons state?

Question

0.00/5 (No votes)

See more:

Hi all.

I am designing a software that uses a simple text editor, based on scintilla.
The software has a tool bar, where the buttons' state are defined by external scintilla's flags. I've achieved this inside the WinMain's message loop, calling the handler function that checks the flags and updates the tool bar.

My questions are:
Is this the best way to handle the buttons state update? (hoping that is not...)
Does it adds great overhead to the program?

Thanks!

Paulo Sherring.

Posted 28-Oct-11 9:14am

PauloSherring

Updated 28-Oct-11 9:18am

André Kraak

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2011-10-28T11:03:00

Normally, in the case of text editor, this is done on every state update of the text buffers, including creation a new one, closing, changing focused tab, etc., In other words — states of any documents. No it is not. :-)

(I mean, you can do it in a more fine-grain manner, but you can hardly win any noticeable performance. Where a single user input is involved, one millisecond or few does not count. Better put all updates in one single call like UpdateControlStates and call in from all the highest-level event handlers of the event which can potentially update a document state. This will ensure your code is kept simple and you have a less chance of a bug.)

—SA