Please someone help me with this C++ code? i keep getting 0 for total

Question

1.00/5 (1 vote)

See more:

, +

C++

#include <iostream>
#include <iomanip>
using namespace std;
int main()
{
	int number1 = 0;
	double total = 0.0;
	char currency = ' ';

	cout << "Enter amount of us dollars: ";
	cin >> number1;

	cout << "What currency would you like to convert it to?" << endl;
	
	cout << "Canada Dollar (CD)" << endl;
	cout << "Eurozone Euro (EE)" << endl;
	cout << "India Rupee (IR)" << endl;
	cout << "Japan Yen (JY)" << endl;
	cout << "Mexico Peso (MP)" << endl;
	cout << "South Africa Rand (SAR)" << endl;
	cout << "United Kingdom Pound (UKP)" << endl;
	
	cout << "Choose currency by the letter(s) in the parentheses: ";
	cin >> currency;

	if  (currency == 'CD')
		total = 1.01615 * number1;
	else if (toupper (currency == 'EE'))
		total = .638490 * number1;
	else if (toupper (currency == 'IR'))
		total = 40.1798 * number1;
	else if (toupper (currency == 'JY'))
		total = 104.390 * number1;
	else if (toupper (currency == 'MP'))
		total = 10.4613 * number1;
	else if (toupper (currency == 'SAR'))
		total = 7.60310 * number1;
	else if (toupper (currency == 'UKP'))	
		total = .504285 * number1;

	cout << "Currency converted: " << total << endl;
	

	system("pause");
	return 0;
}

Posted 5-Oct-11 15:52pm

zach gonzales

Updated 5-Oct-11 17:12pm

walterhevedeich

v2

Add a Solution

Comments

Sergey Alexandrovich Kryukov 6-Oct-11 1:12am

Did you hard-coded the rates because you think that rates never change or you think there is another reason for it? :-)
--SA

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

techone37 · Answer 1 · 2011-10-05T17:45:00

int number1 = 0;
double total = 0.0;

Change to :

float number1;
float total;

Because a ex: 10.23 is float just 10.00 is 10 is also float.

char currency = ' '; is a bad declaration. A char declaration will work only for ONE character, not 2, 3, 5... characters. Change the declarations. A re-design of your code will work if you use 1 character. example : CD is C, EE is E ....

I try your code, and it did not work. The if statement was not executed. I change if (currency=='C') and I put C , it did work. So :

char currency = ' '; Work only for a ONE Character.
But a string of characters, that I did not know how to declare a string of characters , yet.

killabyte · Answer 2 · 2011-10-05T16:13:00

Solution 1

change the type of number1 to double, or cast when you multiply

Posted 5-Oct-11 16:13pm

killabyte

techone37 · Answer 3 · 2011-10-06T07:59:00

I change your code here , and I compile with Code::Blocks and tested :

<br />
#include <iostream><br />
#include <iomanip><br />
#include <cstring> // string.h header for the strcmp()<br />
#include <cstdio><br />
<br />
using namespace std;<br />
<br />
int main()<br />
{<br />
      float number1=0; // float here<br />
      float total=0; // float here<br />
     char currency[4]; // change into a array of strings<br />
<br />
     cout << "Enter amount of us dollars: ";<br />
     cin >> number1;<br />
<br />
     cout << "What currency would you like to convert it to?" << endl;<br />
<br />
     cout << "Canada Dollar (CD)" << endl;<br />
     cout << "Eurozone Euro (EE)" << endl;<br />
     cout << "India Rupee (IR)" << endl;<br />
     cout << "Japan Yen (JY)" << endl;<br />
     cout << "Mexico Peso (MP)" << endl;<br />
     cout << "South Africa Rand (SAR)" << endl;<br />
     cout << "United Kingdom Pound (UKP)" << endl;<br />
<br />
     cout << "Choose currency by the letter(s) in the parentheses: ";<br />
     cin >> currency;<br />
     // use str(currency,"currency_code_here")==0<br />
     if   (strcmp(currency,"CD")==0)<br />
          total = 1.01615 * number1;// like this one<br />
     else if (toupper (currency == 'EE'))<br />
          total = .638490 * number1;<br />
     else if (toupper (currency == 'IR'))<br />
          total = 40.1798 * number1;<br />
     else if (toupper (currency == 'JY'))<br />
          total = 104.390 * number1;<br />
     else if (toupper (currency == 'MP'))<br />
          total = 10.4613 * number1;<br />
     else if (toupper (currency == 'SAR'))<br />
          total = 7.60310 * number1;<br />
     else if (toupper (currency == 'UKP'))<br />
          total = .504285 * number1;<br />
     <br />
<br />
     cout << "Currency converted: " << total << endl;<br />
<br />
<br />
    // system("pause");<br />
     return 0;<br />
}<br />
<br />
<br />
</cstdio></cstring></iomanip></iostream>

Please someone help me with this C++ code? i keep getting 0 for total

3 solutions

Solution 2

Solution 1

Solution 3

Add your solution here

Preview 0