Which is better if condition : using conditional OR or calling repeatedly if

Question

0.00/5 (No votes)

See more:

Hello friends,

1) repeatedly call if

C#

if (i == 1)
    return false;
if (i == 2)
    return false;
if (i == 3)
    return false;
if (i == 4)
    return false;
if (i == 5)
    return false;
if (i == 6)
    return false;

2) conditional OR

C#

if (i == 1 || i == 2 || i == 3 || i == 4 || i == 5 || i == 6)
                return false;

Here you can see two different logic..

I want to know which is better as a performance or as a good programmer and why.

Thanks

Posted 17-Sep-11 3:17am

AditSheth

Add a Solution

Comments

DaveAuld 17-Sep-11 9:19am

Homework question? Think about http://en.wikipedia.org/wiki/Short-circuit_evaluation

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard MacCutchan · Answer 1 · 2011-09-17T04:00:00

Solution 1

In this case you would be better using an expression that uses && (and).

Posted 17-Sep-11 4:00am

Richard MacCutchan

Comments

AditSheth 17-Sep-11 10:42am

Thanks for reply..
can you explain me why it is.as flexibility , quicker execution..

Richard MacCutchan 17-Sep-11 11:22am

In your case you could write if (i > 0 && i <= 6).

OriginalGriff 17-Sep-11 10:49am

This may be mine brain freezing up due to trying to find a replacement microswitch while a kitten eats my keyboard, but how is AND going to help in the OP's expression? :confused:

Richard MacCutchan 17-Sep-11 11:22am

See my reply above.

OriginalGriff 17-Sep-11 11:29am

:doh: It's brain freeze then... :laugh:

Richard MacCutchan 17-Sep-11 12:24pm

What, you as well? :laugh:

OriginalGriff · Answer 2 · 2011-09-17T04:02:00

Solution 2

Try:

C#

switch (i)
   {
   case 1:
   case 2:
   case 3:
   case 4:
   case 5:
   case 6:
      return false;
   }

Why? It's easier to read, it's more flexible, and it's quicker to execute!

Posted 17-Sep-11 4:02am

OriginalGriff

Comments

AditSheth 17-Sep-11 10:39am

case is like a if else condition. but here only if conditions...
Thanks for reply