SQL Database Update using C#

Question

0.00/5 (No votes)

See more:

I'm trying to update my database using windows application i have already created connection string,

i want only update selected rows

My update codes
// da is as data adapter

SQL

da.UpdateCommand = new SqlCommand("UPDATE complain SET Name = @NAME,Email = @EMAIL,Message= @MESSAGE", con);
           da.UpdateCommand.Parameters.Add("@NAME", SqlDbType.NVarChar).Value = nameTextBox.Text;
           da.UpdateCommand.Parameters.Add("@EMAIL", SqlDbType.NVarChar).Value = emailTextBox.Text;
           da.UpdateCommand.Parameters.Add("@MESSAGE", SqlDbType.NVarChar).Value = messageTextBox.Text;

           con.Open();
           da.UpdateCommand.ExecuteNonQuery();
           con.Close();

it does update but it effect to whole database so help me please correct me if I'm wrong
Thank you

Posted 8-Sep-11 2:13am

maxxxn

Updated 11-Aug-21 4:24am

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

nagendrathecoder · Answer 1 · 2011-09-08T02:17:00

Solution 1

You have not provided any Where clause in your query.
If you don't provide any Where clause, it will update whole table.

Posted 8-Sep-11 2:17am

nagendrathecoder

Comments

[no name] 8-Sep-11 8:47am

Good :)

Om Prakash Pant · Answer 2 · 2011-09-08T02:20:00

Solution 3

your update statement will update all records...
you also need to add a where clause... something like..

"UPDATE complain SET Name = @NAME,Email = @EMAIL,Message= @MESSAGE WHERE primary_key= ????"

Posted 8-Sep-11 2:20am

Om Prakash Pant

Comments

[no name] 8-Sep-11 8:47am

Good catch

Member 11548228 26-Mar-15 4:43am

Line 32: TextBox1.Text = query;
Line 33: SqlCommand cmd = new SqlCommand(query, con);
Line 34: int row=cmd.ExecuteNonQuery();// this place Exception Details: System.Data.SqlClient.SqlException: Incorrect syntax near '='.
Line 35: con.Close();
Line 36: }

MaulikDusara · Answer 3 · 2011-09-08T02:48:00

Solution 4

HI,
you just missed WHERE clause in your update statement.
and my another suggestion is that use stored procedure rather than direct sql query on class file.

Posted 8-Sep-11 2:48am

MaulikDusara

Comments

nagendrathecoder 8-Sep-11 8:51am

:)

Suresh Suthar · Answer 4 · 2011-09-08T02:17:00

First thing you have not provide Where clause in update command thats why its updating whole table.

Why are you using DataAdapter here.
You can simply use SqlCommand like this:

SQL

SqlCommand UpdateCommand = new SqlCommand("UPDATE complain SET Name = @NAME,Email = @EMAIL,Message= @MESSAGE", con);
           UpdateCommand.Parameters.Add("@NAME", SqlDbType.NVarChar).Value = nameTextBox.Text;
           UpdateCommand.Parameters.Add("@EMAIL", SqlDbType.NVarChar).Value = emailTextBox.Text;
           UpdateCommand.Parameters.Add("@MESSAGE", SqlDbType.NVarChar).Value = messageTextBox.Text;

           con.Open();
           UpdateCommand.ExecuteNonQuery();
           con.Close();

SQL Database Update using C#

4 solutions

Solution 1

Solution 3

Solution 4

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us