Closing MySql connections in C#

Question

5.00/5 (2 votes)

See more:

I am experimenting with mySQL for use with a c# application. I have come across a problem where connections that are closed aren't closing properly. I did some googling and found there is an option in the connecting string where I can set pooling to false, which does close the connection properly. However if I try this with multiple connections, the application crashes. I came across this article;

http://www.primaryobjects.com/CMS/Article69.aspx

which describes my problem better and has a method of killing the process for each connection, however it will not work for an active connection I just opened. Does anyone know a workaround for this problem or something really obvious that I'm missing.

This is the code I am using:

using (MySqlConnection connection = new MySqlConnection())
                {
                    MySqlDataAdapter data = new MySqlDataAdapter();
                    connection.ConnectionString = "server=127.0.0.1;" +
                        "database=database;" +
                        "uid=root;" +
                        "password=password;";

                    if (connection.State == ConnectionState.Closed)
                    {
                        connection.Open();
                    }

                    MySqlCommand command = connection.CreateCommand();
                    command.CommandText = "select * from T_SCHEDULE";
                    MySqlCommandBuilder thisBuilder = new MySqlCommandBuilder(data);
                    data.SelectCommand = command;
                    DataSet dataset = new DataSet();
                    data.Fill(dataset, "T_SCHEDULE");

                    DataRow thisRow = dataset.Tables[0].NewRow();
                    thisRow[1] = "4000";
                    thisRow[2] = DateTime.Now;
                    thisRow[3] = 12;
                    dataset.Tables["T_SCHEDULE"].Rows.Add(thisRow);

                    DataRow thisRow2 = dataset.Tables[0].NewRow();
                    thisRow2[1] = "4001";
                    thisRow2[2] = DateTime.Now;
                    thisRow2[3] = 12;
                    dataset.Tables["T_SCHEDULE"].Rows.Add(thisRow2);

                    data.Update(dataset, "T_SCHEDULE");

                    connection.Close();
                    connection.Dispose();
                }

Posted 23-Aug-11 23:26pm

Neil Cross

Updated 24-Aug-11 0:33am

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2011-08-24T00:09:00

Try Disposing your connections (and your commands, etc.) that may well dispose of your problem!
The easiest way is to use a using block:

C#

using (MySqlConnection con = new MySqlConnection(strCon))
    {
    con.Open();
    using (MySqlCommand ver = new MySqlCommand("SELECT MAX(version) FROM dlContent WHERE fileName=@FN", con))
        {
        ver.Parameters.AddWithValue("@FN", filename);
        object o = ver.ExecuteScalar();
        if (o != null && o != System.DBNull.Value)
            {
            // Exists already.
            version = (int) o + 1;
            }
        }
    using (MySqlCommand ins = new MySqlCommand("INSERT INTO dlContent (iD, fileName, description, dataContent, version) " +
                                           "VALUES (@ID, @FN, @DS, @DT, @VS)", con))
        {
        ins.Parameters.AddWithValue("@ID", Guid.NewGuid());
        ins.Parameters.AddWithValue("@FN", filename);
        ins.Parameters.AddWithValue("@DS", "");
        ins.Parameters.AddWithValue("@DT", filedata);
        ins.Parameters.AddWithValue("@VS", version);
        ins.ExecuteNonQuery();
        }
    }

Won't help - it comes direct from my Web.Config (redacted version):

XML

<connectionstrings>
  <add name="LoginDatabase" connectionstring="Database=mydatabase;Data Source=localhost;User Id=XXXX;Password=XXXX"></add>
  <add name="LocalMySqlServer" connectionstring="server=localhost;database=XXXX;uid=XXXX;pwd=XXXX" providername="MySql.Data.MySqlClient"></add>
</connectionstrings>