need help create time function in c#

Question

1.00/5 (2 votes)

See more:

Hi
i am trying to create time function in c# so far i have done this

class common
{

    public static int RandNumber()
    {
        Random randomNumber = new Random();
        int RN = randomNumber.Next(23,26);
        return RN;
    }

    public void TimeCheck(string handler)
    {
        Timer time = new Timer();
        time.Elapsed += new ElapsedEventHandler(handler);
        time.Interval = (1000) * (1);
        time.Enabled = true;
        time.Start();

    }


    void timer_Tick(object sender, EventArgs e)
    {
        label.Text = DateTime.Now.ToString();
    }
}

i am trying to create one common function which i can use again and again but it all ways give me error .

Posted 15-Aug-11 22:13pm

vicky87

Add a Solution

Comments

Herman<T>.Instance 16-Aug-11 4:19am

which error you get?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2011-08-15T22:25:00

What are you trying to achieve? Because the code you have posted does not fit together - the three parts are separate, odd, and don't appear to work.

For example, the random number function is really useless:

C#

public static int RandNumber()
{
    Random randomNumber = new Random();
    int RN = randomNumber.Next(23,26);
    return RN;
}

If you call this several times in quick succession, you will almost certainly get the same number. Move you random number generator to a class level variable instead:

C#

Random randomNumber = new Random();
public static int RandNumber()
   {
   return randomNumber.Next(23,26);
   }

Which almost asks "why have it as a separate method at all?"

Plus, don't use "magic numbers" in you code - convert them to const values with sensible names instead. That way, if they need to change, you only have to change them in one place.

Your other method is equally odd: I don't think you have thought about your task in any detail.

*dan!sh* · Answer 2 · 2011-08-15T22:28:00

Solution 2

I see you are using timer from System.Timers namespace. You have not written the Elapsed event handler yet. You have written Tick event handler which comes with System.Windows.Forms.Timer class.

I guess you are new to .Net or C#. So I would suggest reading a book or two and then proceed.

Posted 15-Aug-11 22:28pm

dan!sh

Simon Bang Terkildsen · Answer 3 · 2011-08-15T22:29:00

Solution 3

your timer_Tick method is not invoked on the UI thread thus you cannot set the text of the label. try this:

C#

void timer_Tick(object sender, EventArgs e)
{
    if (label.InvokeRequired)
        label.BeginInvoke((MethodInvoker)(() => label.Text = DateTime.Now.ToString()));
    else
        label.Text = DateTime.Now.ToString();
}

also ElapsedEventHandler doesn't take a string, so you might want to change

C#

time.Elapsed += new ElapsedEventHandler(handler);

to

C#

time.Elapsed += timer_Tick;

Posted 15-Aug-11 22:29pm

Simon Bang Terkildsen

Updated 15-Aug-11 22:33pm

v2

Comments

vicky87 16-Aug-11 11:46am

thanks

but i like to create on function which tick_time and process that tick_time

public void TimeCheck(string handler)
{
Timer time = new Timer();
time.Elapsed += new ElapsedEventHandler(handler);
time.Interval = (1000) * (1);
time.Enabled = true;
time.Start();

}

i pass the values and it process it other wise i have to create many time function .