Fibonacci sequence problems

Question

0.00/5 (No votes)

See more:

I have written code below which does the Fibonacci Sequence the problem I am having is that when I run it against my JUnit Test code only one problem is resolved. I will show you below.

This is my glorious code.....not really.

What I have tried:

import java.util.ArrayList;
 
public class ResitCode {
 
    public int Fib_No(int position) {
        position = 10;
        ArrayList<Integer> a = new ArrayList<Integer>();
        a.add(0);
        a.add(1);
          System.out.println(position); 
        for (int i = 1; i <= position; ++i) {
             
            System.out.println(a.get(0) + " ");
            int sumofBoth = a.get(0) + a.get(1);
            int a1 = a.get(0);
            int a2 = a.get(1);
            a1 = a2;
            a2 = sumofBoth;
          
             
        }
 
        return 0 ;
 
    }

Now this is my Unit Test code

import static org.junit.jupiter.api.Assertions.*;
 
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;
 
class ResitCodeTest {
 
    public static ResitCode test;
     
    @BeforeAll
    static void setUpBeforeClass() throws Exception {
        test = new ResitCode();
    }
 
    @ParameterizedTest
    @DisplayName("Testing Fib_No")
    @CsvSource({
                    "1,0",
                    "2,1",
                    "3,1",
                    "4,2",
                    "8,13",
                    "14,233"                   
    })
    void testFib_No(int pos, int fibno) {
        assertEquals(fibno,test.Fib_No(pos));
    }

When I run it against this only one issue is resolved, if anybody can tell me what i am doing wrong it will be greatly appreciated.

Posted 15-Apr-19 13:49pm

KAID6IX

Updated 15-Apr-19 14:55pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Accepted Answer · 2019-04-15T14:55:00

Quote:
When I run it against this only one issue is resolved, if anybody can tell me what i am doing wrong it will be greatly appreciated.

About anything is wrong.

Java

import java.util.ArrayList;
 
public class ResitCode {
 
    public int Fib_No(int position) {  // here you receive the position you want
        position = 10;  // and here you kill it !
        ArrayList<Integer> a = new ArrayList<Integer>();
        a.add(0);
        a.add(1);
          System.out.println(position); 
        for (int i = 1; i <= position; ++i) {
             
            System.out.println(a.get(0) + " ");
            int sumofBoth = a.get(0) + a.get(1);
            int a1 = a.get(0);
            int a2 = a.get(1);
            a1 = a2;
            a2 = sumofBoth;
          
             
        }
 
        return 0 ;  // Whatever you do, the result is 0 !
 
    }

and those are only 2 problems in this code, about anything else is wrong.
Units are good at checking if your code works as expected, it is not good at helping you fixing the code.
The tool you need to learn is the debugger, it will show you what your code is really doing.
-----
Your code do not behave the way you expect, or you don't understand why !

There is an almost universal solution: Run your code on debugger step by step, inspect variables.
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't know what your code is supposed to do, it don't find bugs, it just help you to by showing you what is going on. When the code don't do what is expected, you are close to a bug.
To see what your code is doing: Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

http://docs.oracle.com/javase/7/docs/technotes/tools/windows/jdb.html[^]
https://www.jetbrains.com/idea/help/debugging-your-first-java-application.html[^]

The debugger is here to only show you what your code is doing and your task is to compare with what it should do.

[Update]

Java

@CsvSource({
                "1,0",
                "2,1",
                "3,1",
                "4,2",
                "8,13",
                "14,233"
})

Even your test unit look wrong f(0)=0, f(1)=1
Fibonacci number - Wikipedia[^]