SQL Server stored procedure insert statement using dynamic table name

Question

0.00/5 (No votes)

See more:

I have a stored procedure something like below

CREATE PROCEDURE [dbo].[spInsert]
@name1 varchar(100),
@name2 varchar(100),
@Id int,
@LastUpdated datetime,
@Volume decimal
AS
BEGIN

declare @tableName varchar(100) = @name1 + '_' + @name2
INSERT INTO  [dbo]. [@tableName]
      ([ID],[LASTUPDATED],[VOLUME])
 VALUES( @Id , @LastUpdated , @Volume)
END

My issue is the table name in the procedure is a variable created inside the procedure. It says the table variable @tableName should be declared.

Also tried dynamic sql (im not sure what i did is dynamic sql or not) like

EXEC(' INSERT INTO  [dbo]. [' + @tableName + ']   
      ([ID],[LASTUPDATED],[VOLUME]) 
 VALUES( ' + @Id + ',' + @LastUpdated + ',' + @Volume + ')' )

This shows no error but record is not added to table.

It would be great if someone let me know how to proceed on this.

Thanks
Nishitha

[edit]SHOUTING removed - OriginalGriff[/edit]

Posted 28-Jun-11 1:03am

nairnishitha

Updated 10-Apr-23 22:34pm

OriginalGriff

v3

Add a Solution

Comments

OriginalGriff 28-Jun-11 7:16am

DON'T SHOUT. Using all capitals is considered shouting on the internet, and rude (using all lower case is considered childish). Use proper capitalisation if you want to be taken seriously.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

hitesh_tech · Answer 1 · 2011-06-28T01:30:00

Solution 1

try changing your dynamic insert statement as below

SQL

' INSERT INTO [dbo]. [' + @tableName + ']
([ID],[LASTUPDATED],[VOLUME])
VALUES( ' + cast(@Id as varchar(20)) + ',' + cast(@LastUpdated as varchar(30)) + ',' + cast(@Volume as varchar(30)) + ')' )

Posted 28-Jun-11 1:30am

hitesh_tech

**R. Giskard Reventlov** · Answer 2 · 2011-06-28T01:36:00

One of the things I always do when creating dynamic sql is to 'print' it first to see what it is producing: great way to mitigate any errors. Anyway, along those lines try something like:

SQL

declare @Id int, @LastUpdated datetime, @Volume decimal
set @Id = 1
set @LastUpdated = getdate()
set @Volume = 10
declare @Sql nvarchar(max), @tableName nvarchar(100)
set @TableName = 'dummy'
set @Sql =
'insert into [dbo].' + @tableName + ' (Id, LastUpdated, Volume)
 values(' + convert(nvarchar, @Id) + ',''' + convert(nvarchar, @LastUpdated) + ''',' + convert(nvarchar, @Volume) + ')'
print @Sql
-- exec sp_executesql @Sql

uncomment the exec when you are ready and, obviously, only use the part pertinent to your requirement.

nairnishitha · Answer 3 · 2011-07-10T21:53:00

Sorry for the delayed reply. I made a mistake while forming the SQL query to be executed using exec(@sql). The datetime data (column named 'LastUpdated') i tried to insert without quotes (string n date type data should be in quotes for insert). Once I corrected that my procedure worked fine.

Thanks all for reply and the above 2 answers looks correct though i did not try as I found what my prob was.

Nishitha

SQL Server stored procedure insert statement using dynamic table name

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0