Error: Invalid Allocation Size

Question

0.00/5 (No votes)

See more:

VS2010

C++

class Stack
{
    int *ptrStack;
    int top;
    int size;

public:
    Stack(int = 10);                    // Default Constructor
};

Stack::Stack(int s): size(s > 0 ? s ? : 10), top(-1), ptrStack (new int[size])
{
     // Body
}

main()
{
     Stack<integer> intStack(7);
}

As I Run the above sample, I get the Debug Error: Invalid Allocation Size. By debugging the sample, I came to know that "size" is not initializes and take some garbage value.
please correct the mistake, I made.

Thanks
Abid

Posted 19-Apr-11 22:58pm

Aabid

Updated 19-Apr-11 23:15pm

Sandeep Mewara

v2

Add a Solution

Comments

Sandeep Mewara 20-Apr-11 4:59am

Looks incomplete code and question.

Can you please edit and update it. Be a little elaborate on the issue and code used.

Aabid 20-Apr-11 5:09am

[Removed the code from here]

Sandeep Mewara 20-Apr-11 5:15am

Updated it for you.

Olivier Levrey 20-Apr-11 5:01am

Please update your question and your code. We can't help with that.

Aabid 20-Apr-11 5:07am

[Removed code from here]

Prerak Patel 20-Apr-11 5:19am

I am just wondering what is size(s > 0 ? s ? : 10)?

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2011-04-19T23:24:00

Solution 2

Aabid wrote:
size(s > 0 ? s ? : 10)

The above should be:

C++

size(s > 0 ? s : 10)

Posted 19-Apr-11 23:24pm

CPallini

Comments

Olivier Levrey 20-Apr-11 5:34am

My 5.

Sergey Alexandrovich Kryukov 20-Apr-11 17:49pm

My 5 too,
--SA

markkuk · Accepted Answer · 2011-04-20T00:06:00

The member variables are initialized in the order they are defined in the class definition, not in the order they appear in the constructor's initialization list. http://codewrangler.home.comcast.net/~codewrangler/tech_info/ctor_init.html#InitializationOrder[^]
http://www.goingware.com/tips/parameters/membervars.html[^]
This causes ptrStack to be initialized first, while size is still undefined. Rearrange your class definition to:

class Stack
{
    int size;
    int top;
    int *ptrStack;
public:
    Stack(int = 10);                    // Default Constructor
};