Parsing output to file

Question

4.25/5 (4 votes)

See more:

Don't know if I'm looking at this tired (since I don't see what's wrong) but I have some code dumping data to a file for analysis:

//open file
ofstream file;
CString name;
name.Format("C:\\%s", title);
file.open(name, ofstream::out | ofstream::app);

//write characters (as append)
for(int i=0; i<size; i++)
{
  file << (int) data[i];
  if((i!=0) && ((i%100) == 0)) 
    file << std::endl;
}

//close file
file.close();

As you can see, I'm inserting line breaks every one hundred characters to make it easier to read, but the first line is always 101 characters, what am I not seeing here?... :doh:

Posted 19-Apr-11 9:30am

Albert Holguin

Add a Solution

3 solutions

Solution 3

The increment happens at the end of the for loop, so you just have put the IF statement before the statement where you are writing into the file.
That's all there is to it! :)

Happy coding,

-MRB

Posted 19-Apr-11 10:01am

Manfred Rudolf Bihy

Comments

Albert Holguin 19-Apr-11 16:05pm

thanks, i must be tired... looking at code all day...

Nish Nishant 19-Apr-11 16:13pm

Voted 5!

Manfred Rudolf Bihy 19-Apr-11 16:15pm

Thanks Nishant!

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick Shaub · Accepted Answer · 2011-04-19T10:01:00

Solution 2

It because you're printing the 100th character and then the endline. Try switching the print statements:

C#

for(int i=0; i<size; i++)
{
    if((i!=0) && ((i%100) == 0))
    {
        file << std::endl;
    }
    file << (int) data[i];
}

Posted 19-Apr-11 10:01am

Rick Shaub

Updated 19-Apr-11 10:05am

v2

Comments

Manfred Rudolf Bihy 19-Apr-11 16:03pm

Correct! 5+

Albert Holguin 19-Apr-11 16:04pm

mbue's solution popped up first on my screen, thanks though! my 5 as well!

mbue 19-Apr-11 16:34pm

If you want to have fast code: reduce the amount of comparisations. my code is most fast as possible. cause im possessed by speed.
Regards.

Albert Holguin 19-Apr-11 16:40pm

lol, this is just debug code, it'll be removed when i'm done anyway... you are right though

Rick Shaub 19-Apr-11 16:40pm

If you were worried about speed, you'd count by 100. Or not. I don't think it matters for this kind of code (test).

Albert Holguin 19-Apr-11 16:43pm

yep, just dumping a bunch of bits to files to see if the program is doing what i expect it to

mbue 19-Apr-11 16:57pm

That would be right, therefore use binary operation they consume a few tick, a division needs about hundred. but its a kind of thinking. what about some million operations they need x% of speed?
The other aspect is the readability of code.
Regards.

Nish Nishant 19-Apr-11 16:13pm

Voted 5!

mbue · Accepted Answer · 2011-04-19T09:56:00

Solution 1

Use:

if(99==(i%100)) // code

Regards.

Posted 19-Apr-11 9:56am

mbue

Comments

Albert Holguin 19-Apr-11 16:02pm

oh, of course! otherwise you end up with 0-100 (101) on the first line... damn, i must be tired.