Looking for a better way to remove role with button ASP.NET MVC

Question

0.00/5 (No votes)

See more:

Hello all,
I currently have this working I have a submit button currently being used to assign roles. I have a second button to remove the roles. To remove the roles I call an $.ajax call and I pass my controller with the id to my action. This works BUT my TempData[msg] isn’t being stored so when the call finishes no message is displayed like when I add a role. Also the Roles are not being refreshed with my ‘return redirectToAction()’ at the end of my action method.
Here is what I have is there a way I can get those small things working or what are some more ideas to do this?
Thank you,

C#

//VIEW This is where I am getting my userId from this DropDownList @Html.AntiForgeryToken()

            <div class="row">
                <div class="col-md-4">
                    @Html.DropDownListFor(a => a.UserId,
                     new SelectList(Model.lstAdmins, "UserId", "Name"),
                     new { @class = "form-control", @id = "userAdmins" })
                    @* , @onChange = "SelectedValue(this)"*@
                    @Html.HiddenFor(a => a.UserId)
                    @Html.ValidationMessageFor(a => a.UserId)
                </div>
                <div class="col-md-4"></div>
                <div class="col-md-4"></div>
            </div><div class="row">
                @for(var i = 0; i < Model.lstUsers.Count(); i++)
                {
                    <div class="col-md-4">
                        <div>
                            @Html.CheckBoxFor(u => Model.lstUsers[i].SelectedUsers)
                            <label>
                                @Html.DisplayFor(u => Model.lstUsers[i].Name)
                                @Html.HiddenFor(u => Model.lstUsers[i].UserId)
                                @Html.HiddenFor(u => Model.lstUsers[i].Name)
                            </label>
                        </div>
                    </div>
                }
            </div>
            <br />
            <div class="row">
                <div class="form-group">
                    <div class="col-md-offset-0 col-md-12">
                        <input type="submit" value="Assign Role" class="btn btn-success" />
                        @* @Url.Action("RemoveAdmin", "SuperAdmin") *@

                        <button type="button" onclick="clickMe()"
                                class="btn btn-danger">
                            Remove Role
                        </button>

                        @Html.ActionLink("Cancel", "Dashboard", "SuperAdmin",
                         null, new { @class = "btn btn-danger" })
                    </div>                                                          <script type="text/javascript">
    //$(function () {

    function clickMe() {
        var userid = $("#userAdmins").val();
        if (userid != "") {
            $.ajax({
                url: "RemoveAdmin/SuperAdmin",
                data: { userid: userid },
                type: "POST",
                //success: function () {
                //    alert("Success");
                //},
                //error: function () {
                //    alert("Error");
                //}
            });
        }
        //window.location.href =
            //'Url.Action("RemoveAdmin", "SuperAdmin")/' + userid;
        //alert("val" + selectedValue);
    }
// CONTROLLER ACTION
[HttpPost]
        //[ValidateAntiForgeryToken]
        public ActionResult RemoveAdmin(string userid)
        {
            ApplicationUser au = context.Users.Where(u => u.Id.Equals(userid,
                StringComparison.CurrentCultureIgnoreCase)).FirstOrDefault();
            var store = new UserStore<ApplicationUser>(context);
            var manager = new UserManager<ApplicationUser>(store);
            manager.RemoveFromRole(au.Id, "Admin");
            manager.AddToRole(au.Id, "User");

            TempData["Success"] = "Roles Assigned Successfully";
            return RedirectToAction("AssignAdmin");
        }

What I have tried:

I used my controller to create a action to addusers to a role that works without any issses and I have 2 methods that gets all the current users with there certain roles. I want this to call my uses so it can display the correct users ether in the dropdown if they are admin or in the lstUsers if they are a normal user. I used javascript to get the value and aajax to make the call but its not working 100% how I want

Posted 3-Apr-19 15:24pm

TheBigBearNow

Updated 4-Apr-19 3:53am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

#realJSOP · Answer 1 · 2019-04-04T01:21:00

Solution 1

(The way I'd do it) Instead of having two buttons, use a checkbox to indicate whether the user does or does not have the role, and have a single submit button.

Posted 4-Apr-19 1:21am

#realJSOP

Richard Deeming · Answer 2 · 2019-04-04T03:54:00

Solution 2

You're making an AJAX request, and doing nothing with the response.

Change your action to return just the redirection URL if the request is an AJAX request:

C#

[HttpPost]
public ActionResult RemoveAdmin(string userid)
{
    ...
    
    TempData["Success"] = "Roles Assigned Successfully";
    if (Request.IsAjaxRequest()) return Json(Url.Action("AssignAdmin"));
    return RedirectToAction("AssignAdmin");
}

Then change your Javascript code so that it navigates to the returned URL when the AJAX request succeeds:

JavaScript

$.ajax({
    url: "RemoveAdmin/SuperAdmin",
    data: { userid: userid },
    type: "POST",
    success: function(result) {
        window.location.assign(result);
    }
});

Posted 4-Apr-19 3:54am

Richard Deeming

Comments

TheBigBearNow 4-Apr-19 18:49pm

This almost solved my problem I feel but it still didnt work.. My project does not refresh on the button click + tempdata msg dont display. Here is my code.

[HttpPost]
        //[ValidateAntiForgeryToken]
        public ActionResult RemoveAdmin(string userid)
        {
            ApplicationUser au = context.Users.Where(u => u.Id.Equals(userid,
                StringComparison.CurrentCultureIgnoreCase)).FirstOrDefault();
            var store = new UserStore<ApplicationUser>(context);
            var manager = new UserManager<ApplicationUser>(store);
            
            manager.RemoveFromRole(au.Id, "Admin");
            manager.AddToRole(au.Id, "User");
            if (Request.IsAjaxRequest())
            {
                TempData["SuccessRole"] = "Role Removed Successfully";
                Json(Url.Action("AssignAdmin"));
                return RedirectToAction("AssignAdmin", "SuperAdmin");
            }
            
            //TempData["Success"] = "Roles Assigned Successfully";
            return RedirectToAction("AssignAdmin");
        }
 function clickMe() {
        var userid = $("#userAdmins").val();
        if (userid != "") {
            $.ajax({
                url: "RemoveAdmin/SuperAdmin",
                data: {
                    userid: userid
                },
                type: "POST",
                success: function (result) {
                    window.location.assign(result);
                }
                //error: function () {
                //    alert("Error");
                //}
            });

Richard Deeming 5-Apr-19 7:22am

You forgot to return the JSON response for an AJAX request:

[HttpPost]
public ActionResult RemoveAdmin(string userid)
{
    ApplicationUser au = context.Users.Where(u => u.Id.Equals(userid, StringComparison.CurrentCultureIgnoreCase)).FirstOrDefault();
    var store = new UserStore<ApplicationUser>(context);
    var manager = new UserManager<ApplicationUser>(store);
    
    manager.RemoveFromRole(au.Id, "Admin");
    manager.AddToRole(au.Id, "User");
    
    TempData["SuccessRole"] = "Role Removed Successfully";
    if (Request.IsAjaxRequest()) return Json(Url.Action("AssignAdmin", "SuperAdmin"));
    return RedirectToAction("AssignAdmin", "SuperAdmin");
}