How to login with that role

Question

1.00/5 (1 vote)

See more:

i use this code to login in bout i don't know what should i bout in ????? i want if it admin open form1 if user open form2

What I have tried:

C#

SqlDataAdapter sda = new SqlDataAdapter("select count(*)  from tbladmin where username='" + txtusername.Text.Trim() + "' and password='" + txtpassword.Text.Trim() + "'", sqlcon);
            DataTable dtbl = new DataTable();
            sda.Fill(dtbl);



            if (dtbl.Rows[0][0].ToString() == "1")
            {
                SqlDataAdapter sda5 = new SqlDataAdapter("select role from tbladmin where username='" + txtusername.Text.Trim() + "' and password='" + txtpassword.Text.Trim() + "'", sqlcon);
                DataTable ds5 = new DataTable();
                sda5.Fill(ds5);
                String value5 = ds5.Rows[0][0].ToString();
                Debug.WriteLine("value is :   " + value5);
                if (????????? = 'admin')
                {

Posted 18-Feb-19 18:51pm

el_tot93

Updated 18-Feb-19 21:22pm

Add a Solution

Comments

Richard MacCutchan 19-Feb-19 3:50am

You have two giant security holes in your code:
1. Storing your passwords in clear text.
2. Using string concatenation to create your SQL commands.

Richard Deeming 20-Feb-19 9:33am

Some light reading for you:

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

Secure Password Authentication Explained Simply[^]
Salted Password Hashing - Doing it Right[^]

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

RickZeeland · Answer 1 · 2019-02-18T21:22:00

You don't need SqlDataAdapter and DataTable to get a value, you can use the more lightweight SqlDataReader, see example here: Retrieving Data Using a DataReader | Microsoft Docs[^]

string value5 = reader.GetString(0));

Also use parameterized queries, especially in security sensitive queries like this one !
See: c# - How to use sql parameters for a select query? - Stack Overflow[^]

If a value is found in tbladmin, it means that an admin was found, other users can be found in tbluser.