C# console app stuck at end of while would like to reenter input n move on if correct

Question

0.00/5 (No votes)

See more:

Hello all I have a loop in a console application. I am using a while loop and grabbing the users input. I am checking the input and if the input isn’t valid I would like to go to the beginning so they can try again. Currently once they are wrong I am stuck at the end it doesn’t matter if they enter the right input again im stuck at the end

C#

for(int i = 0; i < answers.Length; i++)
            {
                Console.WriteLine("Question " + (i + 1) + ": ");
                string input = Console.ReadLine();
                
                if(char.TryParse(input, out char inserted))
                {
                    answers[i] = inserted;

                    // Validate the answer.
                    while (!Valid(answers[i]))
                    {
                        Console.WriteLine("ERROR: Valid answers are A, B, C, or D.");
                        Console.Write("Question " + (i + 1) + ": ");
                        input = Console.ReadLine();
                        if(char.TryParse(input, out char userChar))
                        {
                            answers[i] = inserted;
                        }
                    }
                }
            }

What I have tried:

Moving stuff around and trying to exit the loop but stuck at the end

Posted 18-Dec-18 20:50pm

TheBigBearNow

Updated 18-Dec-18 21:03pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Ehsan Sajjad · Accepted Answer · 2018-12-18T21:04:00

Your following condition seems to be culprit. You are using inserted variable while you are taking input and putting it in userChar.

Either use inserted at both places or change your while condition. Try the following:

C#

if(char.TryParse(input, out char userChar))
{
     answers[i] = userChar; // note this 
}

or you need to use inserted in your TryParse method call:

C#

if(char.TryParse(input, out char inserted))
{
     answers[i] = inserted;
}