Click here to Skip to main content
15,888,286 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
i got this warning "Object reference not set to an instance of an object"
on this line
Quote:
Bitmap histogram = new Bitmap(256, 256, PixelFormat.Format24bppRgb);


What I have tried:

C#
unsafe
        public static Bitmap CreateHistogram(Bitmap source, bool isGray)
        {
             if (source.PixelFormat == PixelFormat.Format24bppRgb)
                {
                    Bitmap histogram = new Bitmap(256, 256, PixelFormat.Format24bppRgb);
                    BitmapData data = source.LockBits(new Rectangle(0, 0, source.Width, source.Height),
                        ImageLockMode.ReadWrite, source.PixelFormat);

                    byte* p = (byte*)data.Scan0;
                    int offset = data.Stride - source.Width * 3;

                    if (isGray == false)
                    {
                        for (int hang = 0; hang < source.Height; hang++)
                        {
                            for (int cot = 0; cot < source.Width; cot++)
                            {
                                //0.21 R + 0.72 G + 0.07 B
                                byte t = (byte)(0.07f * p[0] + 0.72f * p[1] + 0.21 * p[2]);
                                p[0] = p[1] = p[2] = t;
                                p += 3;
                            }
                            p += offset;
                        }
                        p = (byte*)data.Scan0;
                    }



                    int[] count = new int[256];
                    int max = 0;
                    for (int hang = 0; hang < source.Height; hang++)
                    {
                        for (int cot = 0; cot < source.Width; cot++)
                        {
                            count[p[0]]++;


                            if (count[p[0]] > max)
                                max = count[p[0]];

                            p += 3;
                        }
                        p += offset;
                    }
                    source.UnlockBits(data);

                    // max 255
                    // x => x*255/max
                    for (int i = 0; i < 256; i++)
                        count[i] = (int)(count[i] * (histogram.Height - 1) * 1f / max * 1f);


                    data = histogram.LockBits(new Rectangle(0, 0, histogram.Width, histogram.Height),
                        ImageLockMode.ReadWrite, histogram.PixelFormat);
                    p = (byte*)data.Scan0;
                    offset = data.Stride - histogram.Width * 3;

                    for (int cot = 0; cot < histogram.Width; cot++)
                    {
                        for (int hang = 0; hang < histogram.Height; hang++)
                        {
                            byte value = 255;

                            if (hang <= (histogram.Height - count[cot]))
                                value = 255;
                            else
                                value = 0;

                            p[indexOf(hang, cot, data.Stride)] = value;
                            p[indexOf(hang, cot, data.Stride) + 1] = value;
                            p[indexOf(hang, cot, data.Stride) + 2] = value;

                        }
                    }
                    histogram.UnlockBits(data);
                    return histogram;
                }
                else
                {
                    MessageBox.Show("PixelFormat: " + source.PixelFormat);
                    return source;
                }

            }
Posted
Updated 9-Dec-18 10:51am
v2
Comments
Richard MacCutchan 9-Dec-18 12:38pm    
Use your debugger to find out exactly which variable reference is null.

The line of code you pointed out cannot throw that exception. The line after it can, as well as a bunch of others in that code block you posted.

YOU are going to have to use the debugger, run the code, wait for it to break, then start hovering the mouse over variables to find out which one is null. Then you have to trace the code backwards from that point to figure out why it's null.
 
Share this answer
 
This is one of the most common problems we get asked, and it's also the one we are least equipped to answer, but you are most equipped to answer yourself.

Let me just explain what the error means: You have tried to use a variable, property, or a method return value but it contains null - which means that there is no instance of a class in the variable.
It's a bit like a pocket: you have a pocket in your shirt, which you use to hold a pen. If you reach into the pocket and find there isn't a pen there, you can't sign your name on a piece of paper - and you will get very funny looks if you try! The empty pocket is giving you a null value (no pen here!) so you can't do anything that you would normally do once you retrieved your pen. Why is it empty? That's the question - it may be that you forgot to pick up your pen when you left the house this morning, or possibly you left the pen in the pocket of yesterdays shirt when you took it off last night.

We can't tell, because we weren't there, and even more importantly, we can't even see your shirt, much less what is in the pocket!

Back to computers, and you have done the same thing, somehow - and we can't see your code, much less run it and find out what contains null when it shouldn't.
But you can - and Visual Studio will help you here. Run your program in the debugger and when it fails, VS will show you the line it found the problem on. You can then start looking at the various parts of it to see what value is null and start looking back through your code to find out why. So put a breakpoint at the beginning of the method containing the error line, and run your program from the start again. This time, VS will stop before the error, and let you examine what is going on by stepping through the code looking at your values.

But we can't do that - we don't have your code, we don't know how to use it if we did have it, we don't have your data. So try it - and see how much information you can find out!
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900