Issue after opening a usercontrol from one usercontrol on button click

Question

0.00/5 (No votes)

See more:

I have a few UserControls on my C# Windows Form application on clicking of a button on the mainform it wll dock itself to the area on my mainform.

The first usercontrol (IncomeUC) is docked in a panel (panelContainer) on my MainForm when the Income button on my MainForm is clicked. This UC contains a button (Add Income) which once clicked opens the next usercontrol (AddIncomeUC).

But once the AddIncomeUC is opened When i click on the Income button on my Main form to view the IncomeUC (or even if i click any other button to view other main UCs) it is not visible and the AddIncomeUC stays visible.

Is there away to fix this issue? How can i get the AddIncomeUC to hide/close once i click another button?

What I have tried:

This is how the incomeUC is opened on the main form

private void btnIncome_Click(object sender, EventArgs e)
    {
        //when click the income button open the income records view
        //incomeUC1.BringToFront();

        this.panelContainer.Controls.Remove(dashboardUC1);
        this.panelContainer.Controls.Remove(expenseUC1);
        this.panelContainer.Controls.Remove(payerPayeeUC1);
        this.panelContainer.Controls.Remove(reportsUC1);
        this.panelContainer.Controls.Remove(predictionUC1);

        this.panelContainer.Controls.Add(incomeUC1);
        lblViewTitle.Text = "Your Income";
    }

this is how the AddIncomeUC is opened when click the add income button on the IncomeUC

public partial class IncomeUC : UserControl
{
    AddIncomeUC addIncomeUC1;
    public IncomeUC()
    {
        InitializeComponent();
        addIncomeUC1 = new AddIncomeUC();
    }

    private void btnAddIncome_Click(object sender, EventArgs e)
    {
        this.Hide();
        this.Parent.Controls.Add(addIncomeUC1);
    }
}

Posted 21-Nov-18 21:48pm

Member 14063275

Updated 21-Nov-18 22:02pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-11-21T22:03:00

Solution 1

Don't do it like that.
The idea of usercontrols is that they are standalone objects, they shouldn't know about each other (or even about any parent). Instead, they communicate with the parent container (your form) via events and properties, in just the same way you do with separate forms.

Your form creates the first usercontrol, and handles an event. When the usercontrol fires the event, it removes the original usercontrol, and adds the new one, handling an event from that. This sounds complex, but it isn't in practice - it's exactly what you have been doing with all other controls, even the .NET ones!

Have a look here: Transferring information between two forms, Part 3: Child to Child[^] - it's form based but it's exactly the same process (and eveny pretty much the same code!) for UserControl objects.

Posted 21-Nov-18 22:03pm

OriginalGriff

Comments

Member 14063275 22-Nov-18 4:26am

Thank you for your response. I went through that but i do not understand that logic.

OriginalGriff 22-Nov-18 4:34am

Which bit? That's basic OOPs technique!

Member 14063275 22-Nov-18 4:38am

Excuse my lack of knowledge as i am new to c#. I did not understand the "Child Form Event" and the "The parent then passes the information across in the event handler" sections of that article.

OriginalGriff 22-Nov-18 4:54am

OK. Forgive me in advance if I'm talking over your head or teaching your granny to suck eggs - I don't know what you do and don't know and I can't see when your eyes start to glaze over! So if I'm way over your head, tell me, and the same if you learned this stuff ages ago, OK?

What do you know about events?
You know that the whole system is based around them, yes? When you click a button, it raises an event and that causes any handler to be executed.

So in your child form (or usercontrol) you create an event - the code for that is pretty simple:
https://www.codeproject.com/Articles/400287/A-simple-code-snippet-to-add-an-event
Shows the code, and a simple way to add one to VS in the same way that you type "prop" TAB TAB to create a property template.
When you create the usercontrol in response to a button, you can add events to the control instance - you know that right?

Member 14063275 22-Nov-18 5:02am

Thanks for taking your time to explain to me. Yes i know a button raises an onclick event. So that is in my second user control i should have an event like ""public event EventHandler AddIncome;"" plus the virtual method related to it?

OriginalGriff 22-Nov-18 5:27am

Depends - it's difficult to be precise without being able to see your screen - the idea is that one UserControl shoudln't know about another, or even about it's container. It's not up to the UserControl to decide what happens, it just tells it's container that "the user did this".
So the IncomeUC raises an event when the user clicks it's AddIncome button, and the containing form handles the event and decides what happens. It closes the usercontrol, creates the second one, and shows that.
That way, only the items that need to know about the classes have anything to do with them - the form adds UserControls, so it has to know, but the controls themselves are completely independant and do not know about the outside world at all. That's part of what OOPs is all about!

Make sense?

Member 14063275 22-Nov-18 5:30am

Yes now i understood it a bit better. I will try it out. Thank you.

OriginalGriff 22-Nov-18 5:35am

You're welcome!
Sounds complex, but it's really easy when you get your head round it.

BillWoodruff 22-Nov-18 6:39am

+5 another great example of one of the the best of CodeProject's QA responders ... going the distance !

@originallgriff : do you think it would add to this thread to show another technique using ;switchboard static class to handlle UI transitions ?

OriginalGriff 22-Nov-18 6:49am

You could - but I think he's a bit too much on the beginner side of things at this stage!