Why do I get such warning ?

Question

5.00/5 (1 vote)

See more:

Warning C4477 'sprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 2 has type 'CString'

What I have tried:

sprintf(m_Tip.szUnit, "%s", "for Relay Address");

Posted 14-Nov-18 0:59am

Member 14052778

Updated 14-Nov-18 1:19am

Add a Solution

Comments

MadMyche 14-Nov-18 7:12am

Please provide the relevant code; the line throwing the error as well as the definitions of the variables used within that line

3 solutions

Solution 2

Quote:
sprintf(m_Tip.szUnit, "%s", "for Relay Address");

"for Relay Address" doesn't look a CString to me. Possibly you are reporting the wrong line.

By the way, what is wrong with

C

m_Tip.szUnit = "for Relay Address";

?

Posted 14-Nov-18 1:18am

CPallini

Comments

Richard MacCutchan 14-Nov-18 9:50am

Maybe it needs strcpy.

CPallini 14-Nov-18 12:23pm

I guess m_Tip.szUnit is a CString. A wild guess, I know.

Richard MacCutchan 14-Nov-18 12:30pm

The error message appears to be complaining about the string constant, which is a bit strange.

CPallini 14-Nov-18 12:38pm

It is massively strange. As matter of fact, I believe the OP didn't report exactly the offending line.

Richard MacCutchan 14-Nov-18 12:40pm

No surprise there. :(

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-11-14T01:11:00

Solution 1

See here: c++ - How sprintf works with CString and std::string - Stack Overflow[^]

Posted 14-Nov-18 1:11am

OriginalGriff

Comments

CHill60 14-Nov-18 7:21am

5'd - didn't see your solution (nor CPallini's) until after I posted

CHill60 · Accepted Answer · 2018-11-14T01:20:00

Solution 3

Try using a char array for your text e.g.

C++

char s[] = "for Relay Address";
sprintf(m_Tip.szUnit, "%s", s);

Or in this case

C++

m_Tip.szUnit = "for Relay Address";

assuming m_Tip.szUnit is defined as std::string

Posted 14-Nov-18 1:20am

CHill60