I want two select statements in SQL server in one column using or

Question

1.00/5 (1 vote)

See more:

i have two tables namely student and users. In student table i am having fields Id, Name, Password. In users table i am having id, name, password etc.

Now my question is select two tables with password column only in stored procedure. In this line i want to use OR for selecting two tables. Why i require is if the user changes the password then it has to check whether the user is in the student table or user table. For this i am setting a value to local variable with that variable accessing the tables and updating the password.

This password fields varchar(max) datatype

What I have tried:

SET @@CurrentPassword4db = ((SELECT [Password] FROM Users WHERE UserId = @guidUserId) OR (SELECT [Password] FROM Student WHERE StudentId = @guidStudentId))

Can anyone tell me the correct way to achieve this goal. Thanks in advance
Here

@@CurrentPassword4db is varchar(max)

datatype

Posted 29-Sep-18 20:39pm

Member 8583441

Updated 29-Sep-18 21:41pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2018-09-29T21:42:00

Several things wrong here:
1) Never store passwords in clear text - it is a massive security problem. Passwords should be hashed, and the hash value stored in the DB. This requires changes to your presentation software, and there is an example here for C#: Password Storage: How to do it.[^]

2) Why have two tables storing the same thing? That just risks potential duplication and problems. Instead, have one table with a column that says if the row is for a User or a Student. That way all your login, registration, change password, etc. code becomes a whole load cleaner as it is all stored in the same place. With your scheme, it's quite possible to get the same userID in two different tables and then you never know what is going on!