Click here to Skip to main content
15,886,724 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
//This is Admin Login form
package Admin_Login;
import AdminPanel.AdminSection;
import database.db;
import java.sql.*;
import javax.swing.JOptionPane;
public class AdminLogin extends javax.swing.JFrame
{
     Connection conn;
     PreparedStatement pst;
     ResultSet rs;
     AdminSection as;
     public AdminLogin()
     {
         initComponents();
     }
     private void LoginActionPerformed(java.awt.event.ActionEvent evt) {
     String sql="select id,username,password from Users where(username=? and password=?)";
     try
      {
           int count =0;
           pst = conn.prepareStatement(sql);
           pst.setString(1, username.getText());
           pst.setString(2, password.getText());
           rs =pst.executeQuery();
           while(rs.next())
            {
               count =count+1;
            }
           if(count==1)
                {
                    JOptionPane.showMessageDialog(null, "Success Login");
                    as= new AdminSection();
                    as.setVisible(true);
                    this.dispose();
                }
           else
                {
                   JOptionPane.showMessageDialog(null, "Username and
                    Password you entered are not valid");
                }
       }
       catch(Exception e)
       {

       }
        finally
       {
           try
           {

               pst.close();
           }
           catch(Exception e)
           {
               JOptionPane.showMessageDialog(null, e);
           }
       }
    }

        /* Create and display the form */
        java.awt.EventQueue.invokeLater(new Runnable() {
            public void run()
            {
                new AdminLogin().setVisible(true);
            }
        });
    }

    // Variables declaration - do not modify
    private javax.swing.JButton Login;
    private javax.swing.JLabel jLabel1;
    private javax.swing.JLabel jLabel2;
    private javax.swing.JLabel jLabel3;
    private javax.swing.JPanel jPanel1;
    private javax.swing.JTextField password;
    private javax.swing.JTextField username;
    // End of variables declaration
    }



**

//This is Database Class
------------------------

**

    package database;
    import Classes.add_Librarian;
    import java.sql.*;
    import javax.swing.*;
    public class db 
    {
        private Connection conn;
        private Statement st;
        private ResultSet rs;
        public  static Connection establishConnection()
        {
            try
            {
               Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver");
             Connection conn=DriverManager.getConnection("jdbc:sqlserver://localhost\\sqlexpress:1433; database=Employee Payroll; user=pak; password=123");
               if(conn==null)
               {
                   JOptionPane.showMessageDialog(null, "Not Connected");
               }
               else
               {
                   JOptionPane.showMessageDialog(null, "Connected");
               }
               
               return conn;
            }catch(Exception ex)
            {
               JOptionPane.showMessageDialog(null,"Connection not established");
               return null;
            }
        }
        public int addlibrarian (add_Librarian lb)
        {
            int n=0;
            try
            {
                n=st.executeUpdate("insert into Add_Librarian values ('"+lb.getName()+"','"+lb.getFatherName()+"',"
                        +lb.getID_CardNo()+"','"+lb.getQualification()+"','"+lb.getContactNo()+"','"+lb.getAddress()+"')");
            }
            catch(Exception e)
            {
                JOptionPane.showMessageDialog(null,e);
            }
            return n;
        }
        public void closeConnection()
         {
             try
             {
                 conn.close();
             }
             catch(Exception ex)
             {
                        JOptionPane.showMessageDialog(null,ex);
        
             }
         }
    }


What I have tried:

//This is Admin Login form


H, When I run this AdminLogin form, then I face again and again Error of
Java.Lang.NullPointerException error. Please, Anybody, solve my problem.T hanks.
I have attached code of database DB class and AdminLogin Form code both.
------------------------------------------------------------------------

*
Posted
Updated 5-Sep-18 8:05am

1 solution

Ignore ing the problem you have noticed for a moment ... you have bigger ones you arent; aware of.

Never concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Always use Parameterized queries instead.

When you concatenate strings, you cause problems because SQL receives commands like:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'Baker's Wood'
The quote the user added terminates the string as far as SQL is concerned and you get problems. But it could be worse. If I come along and type this instead: "x';DROP TABLE MyTable;--" Then SQL receives a very different command:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';DROP TABLE MyTable;--'
Which SQL sees as three separate commands:
SQL
SELECT * FROM MyTable WHERE StreetAddress = 'x';
A perfectly valid SELECT
SQL
DROP TABLE MyTable;
A perfectly valid "delete the table" command
SQL
--'
And everything else is a comment.
So it does: selects any matching rows, deletes the table from the DB, and ignores anything else.

So ALWAYS use parameterized queries! Or be prepared to restore your DB from backup frequently. You do take backups regularly, don't you?
I know you know how to - your login code does - so always do it - or your INSERT code is going to bite you, hard. And you will have no idea who did it, or when, or how to fix it ...

And parameterised queries are about the only thing your login code gets right ... Never store passwords in clear text - it is a major security risk. There is some information on how to do it here: Password Storage: How to do it.[^] - the code is in C#, but it should be pretty obvious to anyone with Java experience.

And the problem you noticed? We can't fix it for you, because we can't run your code under the same circumstances you do; we don't have any access to your inputs of database. So it will be up to you to fix it. This is one of the most common problems we get asked, and it's also the one we are least equipped to answer, but you are most equipped to answer yourself.

Let me just explain what the error means: You have tried to use a variable, property, or a method return value but it contains null - which means that there is no instance of a class in the variable.
It's a bit like a pocket: you have a pocket in your shirt, which you use to hold a pen. If you reach into the pocket and find there isn't a pen there, you can't sign your name on a piece of paper - and you will get very funny looks if you try! The empty pocket is giving you a null value (no pen here!) so you can't do anything that you would normally do once you retrieved your pen. Why is it empty? That's the question - it may be that you forgot to pick up your pen when you left the house this morning, or possibly you left the pen in the pocket of yesterdays shirt when you took it off last night.

We can't tell, because we weren't there, and even more importantly, we can't even see your shirt, much less what is in the pocket!

Back to computers, and you have done the same thing, somehow - and we can't see your code, much less run it and find out what contains null when it shouldn't.
But you can - and Visual Studio will help you here. Run your program in the debugger and when it fails, VS will show you the line it found the problem on. You can then start looking at the various parts of it to see what value is null and start looking back through your code to find out why. So put a breakpoint at the beginning of the method containing the error line, and run your program from the start again. This time, VS will stop before the error, and let you examine what is going on by stepping through the code looking at your values.

But we can't do that - we don't have your code, we don't know how to use it if we did have it, we don't have your data. So try it - and see how much information you can find out!
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900