Why am I getting garbage value in the output along with the result?

Question

0.00/5 (No votes)

See more:

C++

#include <stdio.h>
void fun (char s1[]);
#define size 10
int main() 
{
     char s1 [size]="feb";
     fun (s1);
     return 0;
}
void fun (char s1[])
{
    char s2[size];
    int i=0;
    while (*s1 !='\0')
    {
        s2 [i]=*s1;
        s1++;
        i++;
    }
    printf ("\n%s",s2);
}

What I have tried:

Above code is just an example. I wanted to compare two strings in the function. Hence i am passing the string to another character variable. But it is resulting into garbage value along with the result. Why garbage values have been added here?

Posted 2-Sep-18 1:27am

Member 13922884

Updated 2-Sep-18 7:59am

KarstenK

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Daniel Pfeffer · Accepted Answer · 2018-09-02T01:47:00

In your function fun(), you are copying everything up to the terminating '\0' character, but do not copy the '\0'. This means that the string 's2' is un-terminated.

A standard function exists - strcpy(), defined in <string.h> - that copies a string including the terminating '\0' character. You should use library functions where possible, unless you have a very good reason for doing otherwise. Mistakes like this one are one reason. :)