C# make a string in a foreach

Question

1.00/5 (1 vote)

See more:

I have to take some words from a file and put them in a new string. I am stuk when i have to make a new string with that "k" var.

I have to do a string with all "k" values.

Thanks

What I have tried:

class Program
   {


       static void Main()
       {
           string[] text1 = new string[] { }; //i tried with a string but... nothing
           string text = System.IO.File.ReadAllText(@"Dat is my file location");
           List<string> list = new List<string>();  ///not even with a list... now i try to put the "k" to an list and after it to convert to string.. but nothing too :(

           Regex pattern1 = new Regex("(?<=ECU_ADDRESS).*?(?=)", RegexOptions.RightToLeft);               //The start and stop of my file
           MatchCollection allMatches1 = pattern1.Matches(text);
           StringBuilder builder = new StringBuilder();
           foreach (var k in allMatches1)    //here is the "k" var
           {



               Console.WriteLine(k);     // here i want to see all my k
               list.Add(k.ToString());            //   here i tried to see what i
                                                     //   have in list but... nothing
               list.ForEach(Console.WriteLine);

               ////////////////////builder.Append(k).Append(", ");

           }

Posted 29-Aug-18 21:02pm

LRazvan96

Updated 29-Aug-18 21:40pm

v2

Add a Solution

3 solutions

Solution 2

The Matches method doesn't return a collection of strings. It returns instead a collection of, well, Match objects.
You should access the properties of such objects in order to obtain the strings you need. See the sample code in the documentation[^].

Posted 29-Aug-18 21:40pm

CPallini

Solution 3

You are cluttering your code with a lot of random variables that you never use. The problem is quite easy to resolve as @OriginalGriff explained to you yesterday in your question at https://www.codeproject.com/Questions/1258200/How-do-I-writte-a-code-in-Csharp-for-read-some-wor[^].

C#

private static Regex findID= new Regex(
      "(?<=ID Config:\\s+)\\w+(?=\\s)",
    RegexOptions.Multiline
    | RegexOptions.CultureInvariant
    | RegexOptions.Compiled
    );
...
    String InpuText = System.IO.File.ReadAllText(@"Dat is my file location");
    MatchCollection ms = findID.Matches(InputText);
    foreach (Match m in ms)
    {
        Console.WriteLine(m.Value);
    }

Apologies to OG for'fixing' his horrible braces indentation. :)

Posted 29-Aug-18 21:41pm

Richard MacCutchan

Comments

OriginalGriff 30-Aug-18 4:03am

"Apologies to OG for 'ruining' his correct braces indentation."
FTFY! :laugh:

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2018-08-29T21:34:00

For starters, k is not a "word" it's a regex Match class instance, so to get the content it matched, you need to use k.Value, not k
Second, you are trying to write the list inside the loop that builds it - you want that at the end.
Thirdly, you have a StringBuilder and you don't even use it!

This looks like you are just guessing, and hoping it will all work - and that isn;t a strategy that will work, not at all. Stop guess, and start thinking - plan what you are going to do, and then if you don't know how, start breaking that down into smaller steps.

Try this:

string text = System.IO.File.ReadAllText(@"Dat is my file location");
Regex pattern1 = new Regex("(?<=ECU_ADDRESS).*?(?=)", RegexOptions.RightToLeft);               //The start and stop of my file
MatchCollection allMatches = pattern1.Matches(text);
StringBuilder words = new StringBuilder();
foreach (Match match in allMatches)
    {
    words.AppendLine(match.Value);
    }
Console.Write(words.ToString());

But ... your regex looks wrong. It looks like the one I gave you yesterday, but hacked my somebody who doesn't understand regexes:

(?<=ID Config:\\s+)\\w+(?=\\s)

Your version doesn't have a terminating condition (the "(?=\\s)" in mine is a "stop at the first whitespace", yours is just empty, and the ".*?" part says "match absolutely nothing" because "*" means "zero or more repetitions of anything at all", and the "?" after it says "as few as possible" which will always means "none, please".

Stop, look at your data, and work out what exactly identifies the start and end of the text you want to capture. Then use the sample I gave you yesterday and a copy of Expresso to work out what you need: Expresso[^] - it's free, and it examines and generates Regular expressions.