Execute a method in the setter of a property

Question

0.00/5 (No votes)

See more:

I have the property.

C#

private MyModel _selectedModel;
public MyModel SelectedModel
{
   get {return _selectedModel;}
   set {ValidateProperty(ref _selectedModel, value);}
}

ValidateProperty

is a somehow base class which inherits

inotifypropertychanged

. It has

public event PropertyChangedEventHandler PropertyChanged;

But I can't change it because everybody is using it.

My question is when the property changed, I need to call the service. So my code is

private MyModel _selectedModel;
public MyModel SelectedModel
{
   get {return _selectedModel;}
   set
   {
         ValidateProperty(ref _selectedModel, value);
		 if(value != null)
		     CallService(value);
   }
}

Not sure if it is a good practice?

What I have tried:

Thanks for the code support. Maybe use event instead of call service in setter?

Posted 29-Aug-18 14:55pm

Member 12658724

Add a Solution

Comments

Richard Maly 30-Aug-18 3:45am

I am going to go out on a limb and say it sounds okay to me. This is exactly why Properties are different from Variables. However depending on what is happening further along the code there could be side effects. I am assuming this is either SL or XAML so you might want to consider spawning of on a thread so whatever the service does, doesn't block your UI

Christiaan van Bergen 30-Aug-18 9:17am

Be aware that the ValidateProperty method might do some modifications on values before the are transferred to _selectedModel. You are executing your code on the 'value', are you sure you want to do that? Is it not that you want to execute your code on '_selectedModel' ?

And actually your code will execute everytime the value of SelectedModel will be set and not be null. This is somewhat different than it calling your code whenever the property is changed.

And yes, you might be better off creating a new handler responding to the PropertyChanged event.

Member 12658724 30-Aug-18 9:30am

It is a wpf application. When I click a row on the grid, the property changes and will call the service.

Member 12658724 6-Sep-18 20:53pm

I may use event, but not sure how to do it for this case.

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)