Error simple output C++

Question

4.00/5 (1 vote)

See more:

hello help simple output program..
when the int very large is error..
is there a better solution?
like
n = 1000000000000
k = 1000000000001
this will be error

What I have tried:

long long n;
  long long k;
	unsigned int count = 0;
	cin >> n >> k;
	for(int i = 1; i <= n; i++)
	{
		for(int y = i+1; y <= n; y++)
		{
			if(i + y == k)
			{
				count = count + 1;
			}
		}
	}
	cout << count << endl;
	return 0;

Posted 17-Aug-18 6:19am

Member 13906640

Updated 17-Aug-18 10:08am

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Answer 1 · 2018-08-17T07:02:00

Solution 1

On most platforms the C/C++ type unsigned int is 32-bit wide. That means the max. decimal value is 4,294,967,295 which is less than 1,000,000,000,000.

If you need larger values use 64 bit values: unsigned long long or uint64_t (include cstdint with C++11 or stdint.h).

Posted 17-Aug-18 7:02am

Jochen Arndt

Rick York · Answer 2 · 2018-08-17T09:55:00

Solution 2

You used the long long type for n and k and it also needs to be used for i, y, and k because, as Jochen wrote, the limit for count will be reached before it is reached for n and k.

Posted 17-Aug-18 9:55am

Rick York

Patrice T · Answer 3 · 2018-08-17T10:09:00

You know that there is different types of integers, different sizes.
You need to be consistent, you can't have n and k as long long type and expect to use ints as counters with n as the loop limit.

The 2 nested loops are very simple minded, and thus brute force.
Take a sheet of paper and a pencil and solve the problem with small values, write each solution or change your code to print i and j for each solution.
do a little analyze, you should easily be able to remove the inner loop.
with further analyze, you may be able to remove both loops and find a mathematical formula which will give you directly the answer.