Javascript: how to check if array's numbers is in a range

Question

0.00/5 (No votes)

See more:

I have validRange(x,y,z) function, it gets an array and 2 numbers, If array's numbers located in this 2 number's range then it returns true, If the array contains a number that is not in the range, the function returns false. For example` validRange([11,1,15,13,14], 10, 20); this will return false, cause 1 is not in range,
validRange([11,15,13,14], 10, 20) and this will return true.

What I have tried:

I have tried like this, but why is it not working?

function validRange(x, y, z) {
	for(var i = 0; i < x.length; i++){
		if(x[i] > y && x[i] < z){
			return true;
		}
		else{
			return false;
		}
	}
}


console.log(validRange([11,1,15,13,14], 10, 20)); //in this case it returns true, but it must return false

Posted 18-Jul-18 3:09am

Suren97

Updated 18-Jul-18 3:23am

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Jochen Arndt · Accepted Answer · 2018-07-18T03:23:00

Your code checks only the first array value and returns immediately. Return immediately only if the condition is not met and return true finally outside the loop:

javascrip

function validRange(x, y, z) {
    for(var i = 0; i < x.length; i++){
        if(x[i] < y || x[i] > z){
            // Value is outside the range
            return false;
        }
    }
    // All values are inside the range
    return true;
}

Note also that I have changed the condition to be outside the range in a way that values which are identical to one of the limits are treated as valid (it is common with ranges that the limits are included). If this should not be the case, change the to comparisons to <= and >=.