How to add a new parameter to sqlparameter[ ] collection?

Question

0.00/5 (No votes)

See more:

How do i add a new parameter

new SqlParameter("@LastName", app.LastName??"")

to @params in the If condition.

SqlParameter[] @params = {
SqlParameter("@AppId", app.AppId),
									new SqlParameter("@FirstName", app.FirstName??""),
										new SqlParameter("@MiddleName", app.MiddleName ?? ""),
										new SqlParameter("@Gender", app.Gender??""),
};
@params[0].Direction = ParameterDirection.Output;
if (app.AppId == 1)
				{
					SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create_Kiosk", @params);
				}
				else
				{
					SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create", @params);
				}

What I have tried:

@params[0].Direction = ParameterDirection.Output;
if (app.AppId == 1)
				{
@params.Concat(new SqlParameter("@LastName", app.LastName??""));
					SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create_Kiosk", @params);
				}
				else
				{
					SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create", @params);
				}

Posted 17-Jul-18 23:34pm

wizklaus

Updated 19-Jul-18 6:06am

v3

Add a Solution

2 solutions

Solution 1

SqlParameter[] @params;


if (app.AppId == 1)
				{
@params = {
SqlParameter("@AppId", app.AppId),									new SqlParameter("@FirstName", app.FirstName??""),										new SqlParameter("@MiddleName", app.MiddleName ?? ""),										new SqlParameter("@Gender", app.Gender??"")}; //add other params

@params[0].Direction = ParameterDirection.Output;

SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create_Kiosk", @params);
				}
				else
				{
@params = {
SqlParameter("@AppId", app.AppId),									new SqlParameter("@FirstName", app.FirstName??""),										new SqlParameter("@MiddleName", app.MiddleName ?? ""),										new SqlParameter("@Gender", app.Gender??"")}; //add other params

@params[0].Direction = ParameterDirection.Output;

					SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, "Create", @params);
				}

Posted 17-Jul-18 23:55pm

Ziee-M

Comments

wizklaus 18-Jul-18 7:20am

Thanks @Ziee-M. But its not a solution i can accept as i have more than 50 parameters in the source code. I have read other instance where List was used. but cant it be archive with an array? adding a new parameter to sqlparameter[] collection.

Eric Lynch 18-Jul-18 14:58pm

You may want to look at the SqlParameterCollection.AddRange(SqlParameter[]) method, described here: https://docs.microsoft.com/en-us/dotnet/api/system.data.sqlclient.sqlparametercollection

Ziee-M 18-Jul-18 9:11am

Making multiple SqlParameters does not make sense to me, because, a table has always the same number of parameters.
Basically, you should have a unique parameter parser for all of your CRUD method, and reuse it.
In case a paramter is not applicable, you should set a default value for that specific param or just ignore it(you should set that field nullable in the database level)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Accepted Answer · 2018-07-19T06:07:00

An array is a fixed-size data structure. You can't add items to it without creating a new array. The remarks on the Array.Resize method[^] explain:

Quote:
This method allocates a new array with the specified size, copies elements from the old array to the new one, and then replaces the old array with the new one.

A better option would be to use List<T> to store your parameters. If the method you're calling only accepts an array, then you can call the lists's ToArray method[^] to get one.

C#

string procedureName;

var @params = new List<SqlParameter>
{
    new SqlParameter("@AppId", app.AppId) { Direction = ParameterDirection.Output },
    new SqlParameter("@FirstName", app.FirstName ?? ""),
    new SqlParameter("@MiddleName", app.MiddleName ?? ""),
    new SqlParameter("@Gender", app.Gender ?? ""),
};

if (app.AppId == 1)
{
    procedureName = "Create_Kiosk";
    @params.Add(new SqlParameter("@LastName", app.LastName ?? ""));
}
else
{
    procedureName = "Create";
}

SqlHelper.ExecuteNonQuery(cn, CommandType.StoredProcedure, procedureName, @params.ToArray());